package validators import ( "encoding/json" "fmt" "net/url" "slices" "strings" apiv0 "github.com/modelcontextprotocol/registry/pkg/api/v0" "github.com/modelcontextprotocol/registry/pkg/model" ) func ValidateServerJSON(serverJSON *model.ServerJSON) error { // Validate server name exists and format if _, err := parseServerName(*serverJSON); err != nil { return err } // Validate repository if err := validateRepository(&serverJSON.Repository); err != nil { return err } // Validate all packages (basic field validation) for _, pkg := range serverJSON.Packages { if err := validatePackageField(&pkg); err != nil { return err } } // Validate all packages (URL and registry type validation) for _, pkg := range serverJSON.Packages { if err := validatePackage(&pkg); err != nil { return fmt.Errorf("validation failed: %w", err) } } // Validate all remotes for _, remote := range serverJSON.Remotes { if err := validateRemote(&remote); err != nil { return err } } // Validate reverse-DNS namespace matching for remote URLs if err := validateRemoteNamespaceMatch(*serverJSON); err != nil { return err } return nil } func validateRepository(obj *model.Repository) error { // Skip validation for empty repository (optional field) if obj.URL == "" && obj.Source == "" { return nil } // validate the repository source repoSource := RepositorySource(obj.Source) if !IsValidRepositoryURL(repoSource, obj.URL) { return fmt.Errorf("%w: %s", ErrInvalidRepositoryURL, obj.URL) } return nil } func validatePackageField(obj *model.Package) error { if !HasNoSpaces(obj.Identifier) { return ErrPackageNameHasSpaces } // Validate runtime arguments for _, arg := range obj.RuntimeArguments { if err := validateArgument(&arg); err != nil { return fmt.Errorf("invalid runtime argument: %w", err) } } // Validate package arguments for _, arg := range obj.PackageArguments { if err := validateArgument(&arg); err != nil { return fmt.Errorf("invalid package argument: %w", err) } } return nil } // validateArgument validates argument details func validateArgument(obj *model.Argument) error { if obj.Type == model.ArgumentTypeNamed { // Validate named argument name format if err := validateNamedArgumentName(obj.Name); err != nil { return err } // Validate value and default don't start with the name if err := validateArgumentValueFields(obj.Name, obj.Value, obj.Default); err != nil { return err } } return nil } func validateNamedArgumentName(name string) error { // Check if name is required for named arguments if name == "" { return ErrNamedArgumentNameRequired } // Check for invalid characters that suggest embedded values or descriptions // Valid: "--directory", "--port", "-v", "config", "verbose" // Invalid: "--directory ", "--port 8080" if strings.Contains(name, "<") || strings.Contains(name, ">") || strings.Contains(name, " ") || strings.Contains(name, "$") { return fmt.Errorf("%w: %s", ErrInvalidNamedArgumentName, name) } return nil } func validateArgumentValueFields(name, value, defaultValue string) error { // Check if value starts with the argument name (using startsWith, not contains) if value != "" && strings.HasPrefix(value, name) { return fmt.Errorf("%w: value starts with argument name '%s': %s", ErrArgumentValueStartsWithName, name, value) } if defaultValue != "" && strings.HasPrefix(defaultValue, name) { return fmt.Errorf("%w: default starts with argument name '%s': %s", ErrArgumentDefaultStartsWithName, name, defaultValue) } return nil } func validateRemote(obj *model.Remote) error { if !IsValidURL(obj.URL) { return fmt.Errorf("%w: %s", ErrInvalidRemoteURL, obj.URL) } return nil } func validateMCPBPackage(host string) error { allowedHosts := []string{ "github.com", "www.github.com", "gitlab.com", "www.gitlab.com", } isAllowed := false for _, allowed := range allowedHosts { if host == allowed { isAllowed = true break } } if !isAllowed { return fmt.Errorf("MCPB packages must be hosted on allowlisted providers (GitHub or GitLab). Host '%s' is not allowed", host) } return nil } func validatePackage(pkg *model.Package) error { registryType := strings.ToLower(pkg.RegistryType) // For direct download packages (mcpb or direct URLs) if registryType == "mcpb" || strings.HasPrefix(pkg.Identifier, "http://") || strings.HasPrefix(pkg.Identifier, "https://") { parsedURL, err := url.Parse(pkg.Identifier) if err != nil { return fmt.Errorf("invalid package URL: %w", err) } host := strings.ToLower(parsedURL.Host) // For MCPB packages, validate they're from allowed hosts if registryType == "mcpb" { return validateMCPBPackage(host) } // For other URL-based packages, just ensure it's valid if parsedURL.Scheme == "" || parsedURL.Host == "" { return fmt.Errorf("package URL must be a valid absolute URL") } return nil } // For registry-based packages, no special validation needed // Registry types like "npm", "pypi", "docker-hub", "nuget" are all valid return nil } // ValidatePublishRequest validates a complete publish request including extensions func ValidatePublishRequest(req apiv0.PublishRequest) error { // Validate publisher extensions if err := validatePublisherExtensions(req); err != nil { return err } // Validate the server detail (includes all nested validation) if err := ValidateServerJSON(&req.Server); err != nil { return err } return nil } func validatePublisherExtensions(req apiv0.PublishRequest) error { const maxExtensionSize = 4 * 1024 // 4KB limit // Check size limit for x-publisher extension if req.XPublisher != nil { extensionsJSON, err := json.Marshal(req.XPublisher) if err != nil { return fmt.Errorf("failed to marshal x-publisher extension: %w", err) } if len(extensionsJSON) > maxExtensionSize { return fmt.Errorf("x-publisher extension exceeds 4KB limit (%d bytes)", len(extensionsJSON)) } } return nil } func parseServerName(serverJSON model.ServerJSON) (string, error) { name := serverJSON.Name if name == "" { return "", fmt.Errorf("server name is required and must be a string") } // Validate format: dns-namespace/name if !strings.Contains(name, "/") { return "", fmt.Errorf("server name must be in format 'dns-namespace/name' (e.g., 'com.example.api/server')") } parts := strings.SplitN(name, "/", 2) if len(parts) != 2 || parts[0] == "" || parts[1] == "" { return "", fmt.Errorf("server name must be in format 'dns-namespace/name' with non-empty namespace and name parts") } return name, nil } // validateRemoteNamespaceMatch validates that remote URLs match the reverse-DNS namespace func validateRemoteNamespaceMatch(serverJSON model.ServerJSON) error { namespace := serverJSON.Name for _, remote := range serverJSON.Remotes { if err := validateRemoteURLMatchesNamespace(remote.URL, namespace); err != nil { return fmt.Errorf("remote URL %s does not match namespace %s: %w", remote.URL, namespace, err) } } return nil } // validateRemoteURLMatchesNamespace checks if a remote URL's hostname matches the publisher domain from the namespace func validateRemoteURLMatchesNamespace(remoteURL, namespace string) error { // Parse the URL to extract the hostname parsedURL, err := url.Parse(remoteURL) if err != nil { return fmt.Errorf("invalid URL format: %w", err) } hostname := parsedURL.Hostname() if hostname == "" { return fmt.Errorf("URL must have a valid hostname") } // Skip validation for localhost and local development URLs if hostname == "localhost" || strings.HasSuffix(hostname, ".localhost") || hostname == "127.0.0.1" { return nil } // Extract publisher domain from reverse-DNS namespace publisherDomain := extractPublisherDomainFromNamespace(namespace) if publisherDomain == "" { return fmt.Errorf("invalid namespace format: cannot extract domain from %s", namespace) } // Check if the remote URL hostname matches the publisher domain or is a subdomain if !isValidHostForDomain(hostname, publisherDomain) { return fmt.Errorf("remote URL host %s does not match publisher domain %s", hostname, publisherDomain) } return nil } // extractPublisherDomainFromNamespace converts reverse-DNS namespace to normal domain format // e.g., "com.example" -> "example.com" func extractPublisherDomainFromNamespace(namespace string) string { // Extract the namespace part before the first slash namespacePart := namespace if slashIdx := strings.Index(namespace, "/"); slashIdx != -1 { namespacePart = namespace[:slashIdx] } // Split into parts and reverse them to get normal domain format parts := strings.Split(namespacePart, ".") if len(parts) < 2 { return "" } // Reverse the parts to convert from reverse-DNS to normal domain slices.Reverse(parts) return strings.Join(parts, ".") } // isValidHostForDomain checks if a hostname is the domain or a subdomain of the publisher domain func isValidHostForDomain(hostname, publisherDomain string) bool { // Exact match if hostname == publisherDomain { return true } // Subdomain match - hostname should end with "." + publisherDomain if strings.HasSuffix(hostname, "."+publisherDomain) { return true } return false }