registry/scripts/mirror_data/load_production_data.go
Tadas Antanavicius 2d49e5b68c
fix: prevent NULL status values during migration 008 (#587)
## Summary
- Fixes migration 008 failing with "column contains null values" error
- Adds COALESCE protection to handle 126 servers without status fields
- Includes test utilities to reproduce and verify fixes with production
data

## Problem

Migration 008 was failing in production because:
- 126 out of 781 servers have no `status` field in their JSON
- When extracting `rec.value->>'status'`, these became NULL values
- The `ALTER TABLE servers ALTER COLUMN status SET NOT NULL` constraint
then failed

## Solution

1. **Prevent NULLs during migration**: Use COALESCE to provide 'active'
default when status is NULL/empty
2. **Enhanced debugging**: Added RAISE NOTICE statements to log
problematic values
3. **Safety check**: Double-check that throws exception if any NULLs
remain
4. **Test utilities**: Created mirror_data tools to test migrations with
real production data

## Testing

Created and used `scripts/mirror_data/` tools to:
- Fetch all 781 servers from production API
- Load them into a test database
- Verify the migration fix works correctly

### Results:
- **Before fix**: 126 NULL status values created during migration
- **After fix**: 0 NULL status values, all servers have valid status
- Migration completes successfully with NOT NULL constraint

## Test plan
- [x] Tested locally with production data using mirror_data tools
- [x] Verified 0 NULL values after migration (vs 126 before)
- [x] Confirmed NOT NULL constraint adds successfully
- [ ] Deploy to staging and verify migration succeeds
- [ ] Monitor production deployment

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude <noreply@anthropic.com>
2025-09-30 06:43:26 -07:00

144 lines
4.5 KiB
Go

// This tool was created by Claude Code as a simple way to kick the tires on data migrations
// by loading production data into a test database for migration testing.
// It is not intended for production use.
//
//go:build ignore
package main
import (
"database/sql"
"encoding/json"
"fmt"
"io/ioutil"
"log"
"path/filepath"
"github.com/google/uuid"
_ "github.com/lib/pq"
)
func main() {
// Database connection
db, err := sql.Open("postgres", "postgres://postgres:testpass@localhost:5433/registry_test?sslmode=disable")
if err != nil {
log.Fatal("Failed to connect to database:", err)
}
defer db.Close()
// Run migrations up to a specific point (configure as needed)
maxMigration := 7 // Change this to test different migration states
fmt.Printf("Running migrations 001-%03d...\n", maxMigration)
migrationsDir := "internal/database/migrations"
for i := 1; i <= maxMigration; i++ {
migrationFile := filepath.Join(migrationsDir, fmt.Sprintf("%03d_*.sql", i))
files, err := filepath.Glob(migrationFile)
if err != nil || len(files) == 0 {
log.Fatalf("Migration file %d not found", i)
}
content, err := ioutil.ReadFile(files[0])
if err != nil {
log.Fatalf("Failed to read migration %d: %v", i, err)
}
fmt.Printf(" Applying migration %d: %s\n", i, filepath.Base(files[0]))
if _, err := db.Exec(string(content)); err != nil {
log.Fatalf("Failed to apply migration %d: %v", i, err)
}
}
// Load production data
fmt.Println("\nLoading production data...")
data, err := ioutil.ReadFile("scripts/mirror_data/production_servers.json")
if err != nil {
log.Fatal("Failed to read production data:", err)
}
var prodData struct {
Servers []json.RawMessage `json:"servers"`
}
if err := json.Unmarshal(data, &prodData); err != nil {
log.Fatal("Failed to parse production data:", err)
}
fmt.Printf("Loading %d servers...\n", len(prodData.Servers))
// Prepare insert statement
stmt, err := db.Prepare("INSERT INTO servers (version_id, value) VALUES ($1, $2)")
if err != nil {
log.Fatal("Failed to prepare statement:", err)
}
defer stmt.Close()
// Insert each server
for i, server := range prodData.Servers {
// Generate a unique version_id
versionID := uuid.New().String()
// The server data is already JSON, just insert it
if _, err := stmt.Exec(versionID, server); err != nil {
log.Printf("Failed to insert server %d: %v", i, err)
continue
}
}
fmt.Println("Data loaded successfully!")
// Verify the data
var count int
db.QueryRow("SELECT COUNT(*) FROM servers").Scan(&count)
fmt.Printf("\nTotal servers in database: %d\n", count)
// Check for NULL status values in the JSON
fmt.Println("\nAnalyzing status field in JSON data...")
rows, err := db.Query(`
SELECT
COUNT(*) as total,
COUNT(CASE WHEN value->>'status' IS NULL THEN 1 END) as null_status,
COUNT(CASE WHEN value->>'status' = '' THEN 1 END) as empty_status,
COUNT(CASE WHEN value->>'status' = 'null' THEN 1 END) as string_null_status,
COUNT(CASE WHEN value->>'status' = 'active' THEN 1 END) as active_status,
COUNT(CASE WHEN value->>'status' = 'deprecated' THEN 1 END) as deprecated_status,
COUNT(CASE WHEN value->>'status' = 'deleted' THEN 1 END) as deleted_status
FROM servers
`)
if err != nil {
log.Fatal("Failed to analyze data:", err)
}
defer rows.Close()
if rows.Next() {
var total, nullStatus, emptyStatus, stringNullStatus, activeStatus, deprecatedStatus, deletedStatus int
rows.Scan(&total, &nullStatus, &emptyStatus, &stringNullStatus, &activeStatus, &deprecatedStatus, &deletedStatus)
fmt.Printf(" Total servers: %d\n", total)
fmt.Printf(" NULL status: %d\n", nullStatus)
fmt.Printf(" Empty status: %d\n", emptyStatus)
fmt.Printf(" 'null' string status: %d\n", stringNullStatus)
fmt.Printf(" 'active' status: %d\n", activeStatus)
fmt.Printf(" 'deprecated' status: %d\n", deprecatedStatus)
fmt.Printf(" 'deleted' status: %d\n", deletedStatus)
fmt.Printf(" Other/Invalid: %d\n", total-nullStatus-emptyStatus-stringNullStatus-activeStatus-deprecatedStatus-deletedStatus)
}
// Print sample servers with no status
fmt.Println("\nSample servers with NULL status:")
rows, err = db.Query(`
SELECT value->>'name', value->>'version'
FROM servers
WHERE value->>'status' IS NULL
LIMIT 5
`)
if err == nil {
defer rows.Close()
for rows.Next() {
var name, version string
rows.Scan(&name, &version)
fmt.Printf(" - %s@%s\n", name, version)
}
}
fmt.Printf("\nDatabase is ready for testing migration %03d!\n", maxMigration+1)
}