<!-- Provide a brief summary of your changes --> ## Motivation and Context <!-- Why is this change needed? What problem does it solve? --> The following PR eliminates duplicate struct definitions by migrating the publisher tool to use canonical types from pkg/model, creating a single source of truth across the codebase. The publisher tool previously had its own copies of structs that were duplicated, ie. ServerJSON, Package, Repository, VersionDetail, EnvironmentVariable, RuntimeArgument and a few others which was not optimal **Changes in the PR:** - Refactored the structs to single canonical types located at pkg/model - Refactor the implementation to use/build canonical structures directly - Remove all duplicate definitions (5 structs eliminated) - Publisher now uses model.ServerJSON, model.Package, model.Repository, etc. - Renamed some of the structs to better reflect their use case, i.e. ServerJSON instead of ServerDetail - Fixes an issue where the Remote property was missing from the previous publisher copy of the Server **Benefits:** - Single source of truth - Schema changes in one place - Type safety - Compiler catches mismatches - Enhanced validation - Field constraints and bson tags - Zero breaking changes - Same CLI interface and JSON output - Future-proof - New canonical fields automatically available Supersedes: #217 and #240 ## How Has This Been Tested? <!-- Have you tested this in a real application? Which scenarios were tested? --> Locally ## Breaking Changes <!-- Will users need to update their code or configurations? --> No ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [ ] I have read the [MCP Documentation](https://modelcontextprotocol.io) - [ ] My code follows the repository's style guidelines - [ ] New and existing tests pass locally - [ ] I have added appropriate error handling - [ ] I have added or updated documentation as needed ## Additional context <!-- Add any other context, implementation notes, or design decisions --> --------- Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
111 lines
4 KiB
Go
111 lines
4 KiB
Go
package v0
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"net/http"
|
|
"strings"
|
|
|
|
"github.com/danielgtaylor/huma/v2"
|
|
"github.com/modelcontextprotocol/registry/internal/auth"
|
|
"github.com/modelcontextprotocol/registry/internal/config"
|
|
"github.com/modelcontextprotocol/registry/internal/database"
|
|
"github.com/modelcontextprotocol/registry/internal/service"
|
|
"github.com/modelcontextprotocol/registry/internal/validators"
|
|
apiv1 "github.com/modelcontextprotocol/registry/pkg/api/v1"
|
|
"github.com/modelcontextprotocol/registry/pkg/model"
|
|
)
|
|
|
|
// EditServerInput represents the input for editing a server
|
|
type EditServerInput struct {
|
|
Authorization string `header:"Authorization" doc:"Registry JWT token with edit permissions" required:"true"`
|
|
ID string `path:"id" doc:"Server ID (UUID)" format:"uuid"`
|
|
RawBody []byte `body:"raw"`
|
|
}
|
|
|
|
// RegisterEditEndpoints registers the edit endpoint
|
|
func RegisterEditEndpoints(api huma.API, registry service.RegistryService, cfg *config.Config) {
|
|
jwtManager := auth.NewJWTManager(cfg)
|
|
|
|
// Edit server endpoint
|
|
huma.Register(api, huma.Operation{
|
|
OperationID: "edit-server",
|
|
Method: http.MethodPut,
|
|
Path: "/v0/servers/{id}",
|
|
Summary: "Edit MCP server",
|
|
Description: "Update an existing MCP server (admin only)",
|
|
Tags: []string{"admin"},
|
|
Security: []map[string][]string{
|
|
{"bearer": {}},
|
|
},
|
|
}, func(ctx context.Context, input *EditServerInput) (*Response[apiv1.ServerRecord], error) {
|
|
// Extract bearer token
|
|
const bearerPrefix = "Bearer "
|
|
authHeader := input.Authorization
|
|
if len(authHeader) < len(bearerPrefix) || !strings.EqualFold(authHeader[:len(bearerPrefix)], bearerPrefix) {
|
|
return nil, huma.Error401Unauthorized("Invalid Authorization header format. Expected 'Bearer <token>'")
|
|
}
|
|
token := authHeader[len(bearerPrefix):]
|
|
|
|
// Validate Registry JWT token
|
|
claims, err := jwtManager.ValidateToken(ctx, token)
|
|
if err != nil {
|
|
return nil, huma.Error401Unauthorized("Invalid or expired Registry JWT token", err)
|
|
}
|
|
|
|
// Validate that only allowed extension fields are present
|
|
if err := validators.ValidatePublishRequestExtensions(input.RawBody); err != nil {
|
|
return nil, huma.Error400BadRequest("Invalid request format", err)
|
|
}
|
|
|
|
// Get current server to check permissions against existing name
|
|
currentServer, err := registry.GetByID(input.ID)
|
|
if err != nil {
|
|
if errors.Is(err, database.ErrNotFound) {
|
|
return nil, huma.Error404NotFound("Server not found")
|
|
}
|
|
return nil, huma.Error500InternalServerError("Failed to get current server", err)
|
|
}
|
|
|
|
// Verify edit permissions for this server using the existing server name
|
|
if !jwtManager.HasPermission(currentServer.Server.Name, auth.PermissionActionEdit, claims.Permissions) {
|
|
return nil, huma.Error403Forbidden("You do not have edit permissions for this server")
|
|
}
|
|
|
|
// Parse the validated request body
|
|
var editRequest apiv1.PublishRequest
|
|
if err := json.Unmarshal(input.RawBody, &editRequest); err != nil {
|
|
return nil, huma.Error400BadRequest("Invalid JSON format", err)
|
|
}
|
|
|
|
// Validate the server detail
|
|
validator := validators.NewObjectValidator()
|
|
if err := validator.Validate(&editRequest.Server); err != nil {
|
|
return nil, huma.Error400BadRequest(err.Error())
|
|
}
|
|
|
|
// Prevent renaming servers
|
|
if currentServer.Server.Name != editRequest.Server.Name {
|
|
return nil, huma.Error400BadRequest("Cannot rename server")
|
|
}
|
|
|
|
// Prevent undeleting servers - once deleted, they stay deleted
|
|
if currentServer.Server.Status == model.StatusDeleted && editRequest.Server.Status != model.StatusDeleted {
|
|
return nil, huma.Error400BadRequest("Cannot change status of deleted server. Deleted servers cannot be undeleted.")
|
|
}
|
|
|
|
// Edit the server
|
|
updatedServer, err := registry.EditServer(input.ID, editRequest)
|
|
if err != nil {
|
|
if errors.Is(err, database.ErrNotFound) {
|
|
return nil, huma.Error404NotFound("Server not found")
|
|
}
|
|
return nil, huma.Error400BadRequest("Failed to edit server", err)
|
|
}
|
|
|
|
return &Response[apiv1.ServerRecord]{
|
|
Body: *updatedServer,
|
|
}, nil
|
|
})
|
|
}
|