31e16a18ec<!-- Provide a brief summary of your changes --> Package identifier and version are required for some of the registries else we won't be able to pull the meta data to validate the packages. ## Motivation and Context <!-- Why is this change needed? What problem does it solve? --> This is in continuation to https://github.com/modelcontextprotocol/registry/pull/424 ## How Has This Been Tested? <!-- Have you tested this in a real application? Which scenarios were tested? --> Unit test. ## Breaking Changes <!-- Will users need to update their code or configurations? --> No ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [ ] I have read the [MCP Documentation](https://modelcontextprotocol.io) - [ ] My code follows the repository's style guidelines - [ ] New and existing tests pass locally - [ ] I have added appropriate error handling - [ ] I have added or updated documentation as needed ## Additional context <!-- Add any other context, implementation notes, or design decisions --> Co-authored-by: Avish Porwal <avishporwal@microsoft.com>
121 lines
4.1 KiB
Go
121 lines
4.1 KiB
Go
package registries_test
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/modelcontextprotocol/registry/internal/validators/registries"
|
|
"github.com/modelcontextprotocol/registry/pkg/model"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestValidateMCPB(t *testing.T) {
|
|
ctx := context.Background()
|
|
|
|
tests := []struct {
|
|
name string
|
|
packageName string
|
|
serverName string
|
|
fileSHA256 string
|
|
expectError bool
|
|
errorMessage string
|
|
}{
|
|
{
|
|
name: "empty package identifier should fail",
|
|
packageName: "",
|
|
serverName: "com.example/test",
|
|
fileSHA256: "abc123ef4567890abcdef1234567890abcdef1234567890abcdef1234567890",
|
|
expectError: true,
|
|
errorMessage: "package identifier is required for MCPB packages",
|
|
},
|
|
{
|
|
name: "empty file SHA256 should fail",
|
|
packageName: "https://github.com/example/server/releases/download/v1.0.0/server.mcpb",
|
|
serverName: "com.example/test",
|
|
fileSHA256: "",
|
|
expectError: true,
|
|
errorMessage: "must include a fileSha256 hash for integrity verification",
|
|
},
|
|
{
|
|
name: "both empty identifier and file SHA256 should fail with file SHA256 error first",
|
|
packageName: "",
|
|
serverName: "com.example/test",
|
|
fileSHA256: "",
|
|
expectError: true,
|
|
errorMessage: "must include a fileSha256 hash for integrity verification",
|
|
},
|
|
{
|
|
name: "valid MCPB package should pass",
|
|
packageName: "https://github.com/domdomegg/airtable-mcp-server/releases/download/v1.7.2/airtable-mcp-server.mcpb",
|
|
serverName: "io.github.domdomegg/airtable-mcp-server",
|
|
fileSHA256: "fe333e598595000ae021bd27117db32ec69af6987f507ba7a63c90638ff633ce",
|
|
expectError: false,
|
|
},
|
|
{
|
|
name: "valid MCPB package should pass",
|
|
packageName: "https://github.com/microsoft/playwright-mcp/releases/download/v0.0.36/playwright-mcp-extension-v0.0.36.zip",
|
|
serverName: "com.microsoft/playwright-mcp",
|
|
fileSHA256: "abc123ef4567890abcdef1234567890abcdef1234567890abcdef1234567890",
|
|
expectError: false,
|
|
},
|
|
{
|
|
name: "MCPB package without file hash should fail",
|
|
packageName: "https://github.com/example/server/releases/download/v1.0.0/server.mcpb",
|
|
serverName: "com.example/test",
|
|
fileSHA256: "",
|
|
expectError: true,
|
|
errorMessage: "must include a fileSha256 hash for integrity verification",
|
|
},
|
|
{
|
|
name: "non-existent .mcpb package should fail accessibility check",
|
|
packageName: "https://github.com/example/server/releases/download/v1.0.0/server.mcpb",
|
|
serverName: "com.example/test",
|
|
fileSHA256: "fe333e598595000ae021bd27117db32ec69af6987f507ba7a63c90638ff633ce",
|
|
expectError: true,
|
|
errorMessage: "not publicly accessible",
|
|
},
|
|
{
|
|
name: "invalid URL without mcp anywhere should fail",
|
|
packageName: "https://github.com/example/server/releases/download/v1.0.0/server.tar.gz",
|
|
serverName: "com.example/test",
|
|
fileSHA256: "fe333e598595000ae021bd27117db32ec69af6987f507ba7a63c90638ff633ce",
|
|
expectError: true,
|
|
errorMessage: "URL must contain 'mcp'",
|
|
},
|
|
{
|
|
name: "invalid URL format should fail",
|
|
packageName: "not://a valid url for mcpb!",
|
|
serverName: "com.example/test",
|
|
fileSHA256: "fe333e598595000ae021bd27117db32ec69af6987f507ba7a63c90638ff633ce",
|
|
expectError: true,
|
|
errorMessage: "invalid MCPB package URL",
|
|
},
|
|
{
|
|
name: "non-existent file should fail accessibility check",
|
|
packageName: "https://github.com/nonexistent/repo/releases/download/v1.0.0/mcp-server.tar.gz",
|
|
serverName: "com.example/test",
|
|
fileSHA256: "fe333e598595000ae021bd27117db32ec69af6987f507ba7a63c90638ff633ce",
|
|
expectError: true,
|
|
errorMessage: "not publicly accessible",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
pkg := model.Package{
|
|
RegistryType: model.RegistryTypeMCPB,
|
|
Identifier: tt.packageName,
|
|
FileSHA256: tt.fileSHA256,
|
|
}
|
|
|
|
err := registries.ValidateMCPB(ctx, pkg, tt.serverName)
|
|
|
|
if tt.expectError {
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), tt.errorMessage)
|
|
} else {
|
|
assert.NoError(t, err)
|
|
}
|
|
})
|
|
}
|
|
}
|