<!-- Provide a brief summary of your changes --> ## Motivation and Context <!-- Why is this change needed? What problem does it solve? --> The following PR adds a new v0.1 API version. The goal is to mark v0.1 as a "freeze" point while keeping v0 as the moving target for new features so integrators can start building on top of something stable(r). Details: * This change is quite simple - we re-register the same handlers twice, once as `v0` and once as `v0.1` * Going forward, we'll keep v0.1 frozen while we add changes either on top of both (non-breaking) or we'll have to branch if breaking changes are necessary * We all acknowledge this is not exactly best-practice, but it gives us a way to gather feedback and allow clients to start integrating with the API without breaking them (**note** this implies a follow up PR that would branch the handlers used in v0.1). * For integrators/clients: please provide your feedback - what works well, what doesn't so we can take this into account going towards GA. ## How Has This Been Tested? <!-- Have you tested this in a real application? Which scenarios were tested? --> ## Breaking Changes <!-- Will users need to update their code or configurations? --> No, this just adds a new API version alongside the existing one. ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [ ] I have read the [MCP Documentation](https://modelcontextprotocol.io) - [ ] My code follows the repository's style guidelines - [ ] New and existing tests pass locally - [ ] I have added appropriate error handling - [ ] I have added or updated documentation as needed ## Additional context <!-- Add any other context, implementation notes, or design decisions --> Fixes: #649 Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
53 lines
1.7 KiB
Go
53 lines
1.7 KiB
Go
package v0
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
|
|
"github.com/danielgtaylor/huma/v2"
|
|
"go.opentelemetry.io/otel/attribute"
|
|
"go.opentelemetry.io/otel/metric"
|
|
|
|
"github.com/modelcontextprotocol/registry/internal/config"
|
|
"github.com/modelcontextprotocol/registry/internal/telemetry"
|
|
)
|
|
|
|
// HealthBody represents the health check response body
|
|
type HealthBody struct {
|
|
Status string `json:"status" example:"ok" doc:"Health status"`
|
|
GitHubClientID string `json:"github_client_id,omitempty" doc:"GitHub OAuth App Client ID"`
|
|
}
|
|
|
|
// RegisterHealthEndpoint registers the health check endpoint with a custom path prefix
|
|
func RegisterHealthEndpoint(api huma.API, pathPrefix string, cfg *config.Config, metrics *telemetry.Metrics) {
|
|
huma.Register(api, huma.Operation{
|
|
OperationID: "get-health" + pathPrefix,
|
|
Method: http.MethodGet,
|
|
Path: pathPrefix + "/health",
|
|
Summary: "Health check",
|
|
Description: "Check the health status of the API",
|
|
Tags: []string{"health"},
|
|
}, func(ctx context.Context, _ *struct{}) (*Response[HealthBody], error) {
|
|
// Record the health check metrics
|
|
recordHealthMetrics(ctx, metrics, pathPrefix+"/health", cfg.Version)
|
|
|
|
return &Response[HealthBody]{
|
|
Body: HealthBody{
|
|
Status: "ok",
|
|
GitHubClientID: cfg.GithubClientID,
|
|
},
|
|
}, nil
|
|
})
|
|
}
|
|
|
|
// recordHealthMetrics records the health check metrics
|
|
func recordHealthMetrics(ctx context.Context, metrics *telemetry.Metrics, path string, version string) {
|
|
attrs := []attribute.KeyValue{
|
|
attribute.String("path", path),
|
|
attribute.String("version", version),
|
|
attribute.String("service", telemetry.Namespace),
|
|
}
|
|
|
|
// metric : Up status (1 = healthy, 0 = unhealthy)
|
|
metrics.Up.Record(ctx, 1, metric.WithAttributes(attrs...))
|
|
}
|