31e16a18ec<!-- Provide a brief summary of your changes --> Package identifier and version are required for some of the registries else we won't be able to pull the meta data to validate the packages. ## Motivation and Context <!-- Why is this change needed? What problem does it solve? --> This is in continuation to https://github.com/modelcontextprotocol/registry/pull/424 ## How Has This Been Tested? <!-- Have you tested this in a real application? Which scenarios were tested? --> Unit test. ## Breaking Changes <!-- Will users need to update their code or configurations? --> No ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [ ] I have read the [MCP Documentation](https://modelcontextprotocol.io) - [ ] My code follows the repository's style guidelines - [ ] New and existing tests pass locally - [ ] I have added appropriate error handling - [ ] I have added or updated documentation as needed ## Additional context <!-- Add any other context, implementation notes, or design decisions --> Co-authored-by: Avish Porwal <avishporwal@microsoft.com>
84 lines
2.5 KiB
Go
84 lines
2.5 KiB
Go
package registries
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
"net/http"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/modelcontextprotocol/registry/pkg/model"
|
|
)
|
|
|
|
var (
|
|
ErrMissingIdentifierForPyPI = errors.New("package identifier is required for PyPI packages")
|
|
ErrMissingVersionForPyPi = errors.New("package version is required for PyPI packages")
|
|
)
|
|
|
|
// PyPIPackageResponse represents the structure returned by the PyPI JSON API
|
|
type PyPIPackageResponse struct {
|
|
Info struct {
|
|
Description string `json:"description"`
|
|
} `json:"info"`
|
|
}
|
|
|
|
// ValidatePyPI validates that a PyPI package contains the correct MCP server name
|
|
func ValidatePyPI(ctx context.Context, pkg model.Package, serverName string) error {
|
|
// Set default registry base URL if empty
|
|
if pkg.RegistryBaseURL == "" {
|
|
pkg.RegistryBaseURL = model.RegistryURLPyPI
|
|
}
|
|
|
|
if pkg.Identifier == "" {
|
|
return ErrMissingIdentifierForPyPI
|
|
}
|
|
|
|
if pkg.Version == "" {
|
|
return ErrMissingVersionForPyPi
|
|
}
|
|
|
|
// Validate that the registry base URL matches PyPI exactly
|
|
if pkg.RegistryBaseURL != model.RegistryURLPyPI {
|
|
return fmt.Errorf("registry type and base URL do not match: '%s' is not valid for registry type '%s'. Expected: %s",
|
|
pkg.RegistryBaseURL, model.RegistryTypePyPI, model.RegistryURLPyPI)
|
|
}
|
|
|
|
client := &http.Client{Timeout: 10 * time.Second}
|
|
|
|
url := fmt.Sprintf("%s/pypi/%s/%s/json", pkg.RegistryBaseURL, pkg.Identifier, pkg.Version)
|
|
req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to create request: %w", err)
|
|
}
|
|
|
|
req.Header.Set("User-Agent", "MCP-Registry-Validator/1.0")
|
|
req.Header.Set("Accept", "application/json")
|
|
|
|
resp, err := client.Do(req)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to fetch package metadata from PyPI: %w", err)
|
|
}
|
|
defer resp.Body.Close()
|
|
|
|
if resp.StatusCode != http.StatusOK {
|
|
return fmt.Errorf("PyPI package '%s' not found (status: %d)", pkg.Identifier, resp.StatusCode)
|
|
}
|
|
|
|
var pypiResp PyPIPackageResponse
|
|
if err := json.NewDecoder(resp.Body).Decode(&pypiResp); err != nil {
|
|
return fmt.Errorf("failed to parse PyPI package metadata: %w", err)
|
|
}
|
|
|
|
// Check description (README) content
|
|
description := pypiResp.Info.Description
|
|
|
|
// Check for mcp-name: format (more specific)
|
|
mcpNamePattern := "mcp-name: " + serverName
|
|
if strings.Contains(description, mcpNamePattern) {
|
|
return nil // Found as mcp-name: format
|
|
}
|
|
|
|
return fmt.Errorf("PyPI package '%s' ownership validation failed. The server name '%s' must appear as 'mcp-name: %s' in the package README", pkg.Identifier, serverName, serverName)
|
|
}
|