modelcontextprotocol/ruby-sdk
Watch
1
0
Fork
You've already forked ruby-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #261 from koic/return_404_for_invalid_session_id_in_handle_delete

Browse source 
Return 404 for invalid session ID in `handle_delete`
This commit is contained in:
Koichi ITO 2026-03-21 00:42:55 +09:00 • committed by GitHub
commit 1b8e45fef3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 80 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

78
test/mcp/server/transports/streamable_http_transport_test.rb
View file

@ -332,6 +332,84 @@ module MCP
assert body["success"]
end
test "handles DELETE request with invalid session ID" do
request = create_rack_request(
"DELETE",
"/",
{ "HTTP_MCP_SESSION_ID" => "invalid_id" },
)
response = @transport.handle_request(request)
assert_equal 404, response[0]
assert_equal({ "Content-Type" => "application/json" }, response[1])
body = JSON.parse(response[2][0])
assert_equal "Session not found", body["error"]
end
test "POST returns 404 after session is deleted" do
init_request = create_rack_request(
"POST",
"/",
{ "CONTENT_TYPE" => "application/json" },
{ jsonrpc: "2.0", method: "initialize", id: "init" }.to_json,
)
init_response = @transport.handle_request(init_request)
session_id = init_response[1]["Mcp-Session-Id"]
delete_request = create_rack_request(
"DELETE",
"/",
{ "HTTP_MCP_SESSION_ID" => session_id },
)
@transport.handle_request(delete_request)
post_request = create_rack_request(
"POST",
"/",
{
"CONTENT_TYPE" => "application/json",
"HTTP_MCP_SESSION_ID" => session_id,
},
{ jsonrpc: "2.0", method: "ping", id: "456" }.to_json,
)
response = @transport.handle_request(post_request)
assert_equal 404, response[0]
body = JSON.parse(response[2][0])
assert_equal "Session not found", body["error"]
end
test "DELETE returns 404 after session is already deleted" do
init_request = create_rack_request(
"POST",
"/",
{ "CONTENT_TYPE" => "application/json" },
{ jsonrpc: "2.0", method: "initialize", id: "init" }.to_json,
)
init_response = @transport.handle_request(init_request)
session_id = init_response[1]["Mcp-Session-Id"]
first_delete = create_rack_request(
"DELETE",
"/",
{ "HTTP_MCP_SESSION_ID" => session_id },
)
response = @transport.handle_request(first_delete)
assert_equal 200, response[0]
second_delete = create_rack_request(
"DELETE",
"/",
{ "HTTP_MCP_SESSION_ID" => session_id },
)
response = @transport.handle_request(second_delete)
assert_equal 404, response[0]
body = JSON.parse(response[2][0])
assert_equal "Session not found", body["error"]
end
test "handles DELETE request with missing session ID" do
request = create_rack_request(
"DELETE",