modelcontextprotocol/ruby-sdk
Watch
1
0
Fork
You've already forked ruby-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove duplicate method instrumentation

Browse source 
`handle_request` already adds the `method` to the instrumentation data,
so there is no need to repeat this. Moreover, consumers can override
these anyway.
This commit is contained in:
Sam Bostock 2025-06-17 02:07:25 -04:00
commit ce1c8719cf
No known key found for this signature in database
GPG key ID: 65626A9DAF9ACD95
1 changed files with 0 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

10
lib/mcp/server.rb
View file

@ -176,7 +176,6 @@ module MCP
end end
def init(request) def init(request)
add_instrumentation_data(method: Methods::INITIALIZE)
{ {
protocolVersion: configuration.protocol_version, protocolVersion: configuration.protocol_version,
capabilities: capabilities, capabilities: capabilities,
@ -185,12 +184,10 @@ module MCP
end end
def list_tools(request) def list_tools(request)
add_instrumentation_data(method: Methods::TOOLS_LIST)
@tools.map { |_, tool| tool.to_h } @tools.map { |_, tool| tool.to_h }
end end
def call_tool(request) def call_tool(request)
add_instrumentation_data(method: Methods::TOOLS_CALL)
tool_name = request[:name] tool_name = request[:name]
tool = tools[tool_name] tool = tools[tool_name]
unless tool unless tool
@ -224,12 +221,10 @@ module MCP
end end
def list_prompts(request) def list_prompts(request)
add_instrumentation_data(method: Methods::PROMPTS_LIST)
@prompts.map { |_, prompt| prompt.to_h } @prompts.map { |_, prompt| prompt.to_h }
end end
def get_prompt(request) def get_prompt(request)
add_instrumentation_data(method: Methods::PROMPTS_GET)
prompt_name = request[:name] prompt_name = request[:name]
prompt = @prompts[prompt_name] prompt = @prompts[prompt_name]
unless prompt unless prompt
@ -246,21 +241,16 @@ module MCP
end end
def list_resources(request) def list_resources(request)
add_instrumentation_data(method: Methods::RESOURCES_LIST)
@resources.map(&:to_h) @resources.map(&:to_h)
end end
# Server implementation should set `resources_read_handler` to override no-op default # Server implementation should set `resources_read_handler` to override no-op default
def read_resource_no_content(request) def read_resource_no_content(request)
add_instrumentation_data(method: Methods::RESOURCES_READ)
add_instrumentation_data(resource_uri: request[:uri]) add_instrumentation_data(resource_uri: request[:uri])
[] []
end end
def list_resource_templates(request) def list_resource_templates(request)
add_instrumentation_data(method: Methods::RESOURCES_TEMPLATES_LIST)
@resource_templates.map(&:to_h) @resource_templates.map(&:to_h)
end end