modelcontextprotocol/ruby-sdk
Watch
1
0
Fork
You've already forked ruby-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix Prompt#validate_arguments! crash when arguments are nil

Browse source 
`Prompt#validate_arguments!` called `required_args` which does `arguments_value.filter_map`,
crashing with `NoMethodError` when `arguments_value` is `nil` (the default for prompts without
declared arguments). Additionally, passing `nil` as args caused a crash on `args.keys`.

Fix by defaulting `arguments_value` to `[]` and guarding against `nil` args.
This commit is contained in:
Koichi ITO 2026-02-28 02:51:31 +09:00
commit ef5c76373b
1 changed files with 50 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
lib/mcp/prompt.rb
View file

@ -21,7 +21,7 @@ module MCP
title: title_value,
description: description_value,
icons: icons_value&.then { |icons| icons.empty? ? nil : icons.map(&:to_h) },
arguments: arguments_value&.map(&:to_h),
arguments: arguments_value.empty? ? nil : arguments_value.map(&:to_h),
_meta: meta_value,
}.compact
end
@ -32,7 +32,7 @@ module MCP
subclass.instance_variable_set(:@title_value, nil)
subclass.instance_variable_set(:@description_value, nil)
subclass.instance_variable_set(:@icons_value, nil)
subclass.instance_variable_set(:@arguments_value, nil)
subclass.instance_variable_set(:@arguments_value, [])
subclass.instance_variable_set(:@meta_value, nil)
end
@ -76,7 +76,7 @@ module MCP
if value == NOT_SET
@arguments_value
else
@arguments_value = value
@arguments_value = Array(value)
end
end
@ -103,6 +103,7 @@ module MCP
end
def validate_arguments!(args)
args ||= {}
missing = required_args - args.keys
return if missing.empty?