## Summary When using browser-based MCP clients such as MCP Inspector, connections to the example HTTP server failed due to two issues: 1. CORS preflight (OPTIONS) requests returned 405 Method Not Allowed, causing browsers to block all cross-origin requests. 2. `Accept: */*` (commonly sent by browsers and fetch API) returned 406 Not Acceptable because the transport required the Accept header to explicitly list `application/json` and `text/event-stream`. Add `rack-cors` middleware to the example HTTP servers so that preflight requests are handled correctly and `Mcp-Session-Id` is exposed to browser clients. Also fix `validate_accept_header` in `StreamableHTTPTransport` to treat `*/*` as satisfying all required Accept types. Fixes #141. ## Repro Steps ### 1. Start the example server (Terminal 1) ```console $ bundle exec ruby examples/streamable_http_server.rb ``` ### 2. Start MCP Inspector (Terminal 2) ```console $ npx @modelcontextprotocol/inspector ``` ### 3. Open the Inspector Web UI (http://localhost:6274) in a browser - Set Transport Type to "Streamable HTTP" - Set URL to http://localhost:9393 - Disable the Authorization header toggle (the example server does not require authentication) - Click "Connect" Before this change, the connection fails due to CORS or 406 errors. After this change, the connection succeeds and tools are listed. These steps have been added to examples/README.md.
382 lines
12 KiB
Ruby
382 lines
12 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require_relative "../../transport"
|
|
require "json"
|
|
require "securerandom"
|
|
|
|
module MCP
|
|
class Server
|
|
module Transports
|
|
class StreamableHTTPTransport < Transport
|
|
def initialize(server, stateless: false)
|
|
super(server)
|
|
# { session_id => { stream: stream_object }
|
|
@sessions = {}
|
|
@mutex = Mutex.new
|
|
|
|
@stateless = stateless
|
|
end
|
|
|
|
REQUIRED_POST_ACCEPT_TYPES = ["application/json", "text/event-stream"].freeze
|
|
REQUIRED_GET_ACCEPT_TYPES = ["text/event-stream"].freeze
|
|
STREAM_WRITE_ERRORS = [IOError, Errno::EPIPE, Errno::ECONNRESET].freeze
|
|
|
|
def handle_request(request)
|
|
case request.env["REQUEST_METHOD"]
|
|
when "POST"
|
|
handle_post(request)
|
|
when "GET"
|
|
handle_get(request)
|
|
when "DELETE"
|
|
handle_delete(request)
|
|
else
|
|
method_not_allowed_response
|
|
end
|
|
end
|
|
|
|
def close
|
|
@mutex.synchronize do
|
|
@sessions.each_key { |session_id| cleanup_session_unsafe(session_id) }
|
|
end
|
|
end
|
|
|
|
def send_notification(method, params = nil, session_id: nil)
|
|
# Stateless mode doesn't support notifications
|
|
raise "Stateless mode does not support notifications" if @stateless
|
|
|
|
notification = {
|
|
jsonrpc: "2.0",
|
|
method: method,
|
|
}
|
|
notification[:params] = params if params
|
|
|
|
@mutex.synchronize do
|
|
if session_id
|
|
# Send to specific session
|
|
session = @sessions[session_id]
|
|
return false unless session && session[:stream]
|
|
|
|
begin
|
|
send_to_stream(session[:stream], notification)
|
|
true
|
|
rescue *STREAM_WRITE_ERRORS => e
|
|
MCP.configuration.exception_reporter.call(
|
|
e,
|
|
{ session_id: session_id, error: "Failed to send notification" },
|
|
)
|
|
cleanup_session_unsafe(session_id)
|
|
false
|
|
end
|
|
else
|
|
# Broadcast to all connected SSE sessions
|
|
sent_count = 0
|
|
failed_sessions = []
|
|
|
|
@sessions.each do |sid, session|
|
|
next unless session[:stream]
|
|
|
|
begin
|
|
send_to_stream(session[:stream], notification)
|
|
sent_count += 1
|
|
rescue *STREAM_WRITE_ERRORS => e
|
|
MCP.configuration.exception_reporter.call(
|
|
e,
|
|
{ session_id: sid, error: "Failed to send notification" },
|
|
)
|
|
failed_sessions << sid
|
|
end
|
|
end
|
|
|
|
# Clean up failed sessions
|
|
failed_sessions.each { |sid| cleanup_session_unsafe(sid) }
|
|
|
|
sent_count
|
|
end
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def send_to_stream(stream, data)
|
|
message = data.is_a?(String) ? data : data.to_json
|
|
stream.write("data: #{message}\n\n")
|
|
stream.flush if stream.respond_to?(:flush)
|
|
end
|
|
|
|
def send_ping_to_stream(stream)
|
|
stream.write(": ping #{Time.now.iso8601}\n\n")
|
|
stream.flush if stream.respond_to?(:flush)
|
|
end
|
|
|
|
def handle_post(request)
|
|
accept_error = validate_accept_header(request, REQUIRED_POST_ACCEPT_TYPES)
|
|
return accept_error if accept_error
|
|
|
|
body_string = request.body.read
|
|
session_id = extract_session_id(request)
|
|
|
|
body = parse_request_body(body_string)
|
|
return body unless body.is_a?(Hash) # Error response
|
|
|
|
if body["method"] == "initialize"
|
|
handle_initialization(body_string, body)
|
|
elsif notification?(body) || response?(body)
|
|
handle_accepted
|
|
else
|
|
handle_regular_request(body_string, session_id)
|
|
end
|
|
rescue StandardError => e
|
|
MCP.configuration.exception_reporter.call(e, { request: body_string })
|
|
[500, { "Content-Type" => "application/json" }, [{ error: "Internal server error" }.to_json]]
|
|
end
|
|
|
|
def handle_get(request)
|
|
if @stateless
|
|
return method_not_allowed_response
|
|
end
|
|
|
|
accept_error = validate_accept_header(request, REQUIRED_GET_ACCEPT_TYPES)
|
|
return accept_error if accept_error
|
|
|
|
session_id = extract_session_id(request)
|
|
|
|
return missing_session_id_response unless session_id
|
|
return session_not_found_response unless session_exists?(session_id)
|
|
|
|
setup_sse_stream(session_id)
|
|
end
|
|
|
|
def handle_delete(request)
|
|
success_response = [200, { "Content-Type" => "application/json" }, [{ success: true }.to_json]]
|
|
|
|
if @stateless
|
|
# Stateless mode doesn't support sessions, so we can just return a success response
|
|
return success_response
|
|
end
|
|
|
|
session_id = request.env["HTTP_MCP_SESSION_ID"]
|
|
|
|
return [
|
|
400,
|
|
{ "Content-Type" => "application/json" },
|
|
[{ error: "Missing session ID" }.to_json],
|
|
] unless session_id
|
|
|
|
cleanup_session(session_id)
|
|
success_response
|
|
end
|
|
|
|
def cleanup_session(session_id)
|
|
@mutex.synchronize do
|
|
cleanup_session_unsafe(session_id)
|
|
end
|
|
end
|
|
|
|
def cleanup_session_unsafe(session_id)
|
|
session = @sessions[session_id]
|
|
return unless session
|
|
|
|
begin
|
|
session[:stream]&.close
|
|
rescue
|
|
nil
|
|
end
|
|
@sessions.delete(session_id)
|
|
end
|
|
|
|
def extract_session_id(request)
|
|
request.env["HTTP_MCP_SESSION_ID"]
|
|
end
|
|
|
|
def validate_accept_header(request, required_types)
|
|
accept_header = request.env["HTTP_ACCEPT"]
|
|
return not_acceptable_response(required_types) unless accept_header
|
|
|
|
accepted_types = parse_accept_header(accept_header)
|
|
return if accepted_types.include?("*/*")
|
|
|
|
missing_types = required_types - accepted_types
|
|
return not_acceptable_response(required_types) unless missing_types.empty?
|
|
|
|
nil
|
|
end
|
|
|
|
def parse_accept_header(header)
|
|
header.split(",").map do |part|
|
|
part.split(";").first.strip
|
|
end
|
|
end
|
|
|
|
def not_acceptable_response(required_types)
|
|
[
|
|
406,
|
|
{ "Content-Type" => "application/json" },
|
|
[{ error: "Not Acceptable: Accept header must include #{required_types.join(" and ")}" }.to_json],
|
|
]
|
|
end
|
|
|
|
def parse_request_body(body_string)
|
|
JSON.parse(body_string)
|
|
rescue JSON::ParserError, TypeError
|
|
[400, { "Content-Type" => "application/json" }, [{ error: "Invalid JSON" }.to_json]]
|
|
end
|
|
|
|
def notification?(body)
|
|
!body["id"] && !!body["method"]
|
|
end
|
|
|
|
def response?(body)
|
|
!!body["id"] && !body["method"]
|
|
end
|
|
|
|
def handle_initialization(body_string, body)
|
|
session_id = nil
|
|
|
|
unless @stateless
|
|
session_id = SecureRandom.uuid
|
|
|
|
@mutex.synchronize do
|
|
@sessions[session_id] = {
|
|
stream: nil,
|
|
}
|
|
end
|
|
end
|
|
|
|
response = @server.handle_json(body_string)
|
|
|
|
headers = {
|
|
"Content-Type" => "application/json",
|
|
}
|
|
|
|
headers["Mcp-Session-Id"] = session_id if session_id
|
|
|
|
[200, headers, [response]]
|
|
end
|
|
|
|
def handle_accepted
|
|
[202, {}, []]
|
|
end
|
|
|
|
def handle_regular_request(body_string, session_id)
|
|
unless @stateless
|
|
# If session ID is provided, but not in the sessions hash, return an error
|
|
if session_id && !@sessions.key?(session_id)
|
|
return [400, { "Content-Type" => "application/json" }, [{ error: "Invalid session ID" }.to_json]]
|
|
end
|
|
end
|
|
|
|
response = @server.handle_json(body_string) || ""
|
|
|
|
# Stream can be nil since stateless mode doesn't retain streams
|
|
stream = get_session_stream(session_id) if session_id
|
|
|
|
if stream
|
|
send_response_to_stream(stream, response, session_id)
|
|
elsif response.nil? && notification_request?(body_string)
|
|
[202, { "Content-Type" => "application/json" }, [response]]
|
|
else
|
|
[200, { "Content-Type" => "application/json" }, [response]]
|
|
end
|
|
end
|
|
|
|
def notification_request?(body_string)
|
|
body = parse_request_body(body_string)
|
|
body.is_a?(Hash) && body["method"].start_with?("notifications/")
|
|
end
|
|
|
|
def get_session_stream(session_id)
|
|
@mutex.synchronize { @sessions[session_id]&.fetch(:stream, nil) }
|
|
end
|
|
|
|
def send_response_to_stream(stream, response, session_id)
|
|
message = JSON.parse(response)
|
|
send_to_stream(stream, message)
|
|
handle_accepted
|
|
rescue *STREAM_WRITE_ERRORS => e
|
|
MCP.configuration.exception_reporter.call(
|
|
e,
|
|
{ session_id: session_id, error: "Stream closed during response" },
|
|
)
|
|
cleanup_session(session_id)
|
|
[200, { "Content-Type" => "application/json" }, [response]]
|
|
end
|
|
|
|
def session_exists?(session_id)
|
|
@mutex.synchronize { @sessions.key?(session_id) }
|
|
end
|
|
|
|
def method_not_allowed_response
|
|
[405, { "Content-Type" => "application/json" }, [{ error: "Method not allowed" }.to_json]]
|
|
end
|
|
|
|
def missing_session_id_response
|
|
[400, { "Content-Type" => "application/json" }, [{ error: "Missing session ID" }.to_json]]
|
|
end
|
|
|
|
def session_not_found_response
|
|
[404, { "Content-Type" => "application/json" }, [{ error: "Session not found" }.to_json]]
|
|
end
|
|
|
|
def setup_sse_stream(session_id)
|
|
body = create_sse_body(session_id)
|
|
|
|
headers = {
|
|
"Content-Type" => "text/event-stream",
|
|
"Cache-Control" => "no-cache",
|
|
"Connection" => "keep-alive",
|
|
}
|
|
|
|
[200, headers, body]
|
|
end
|
|
|
|
def create_sse_body(session_id)
|
|
proc do |stream|
|
|
store_stream_for_session(session_id, stream)
|
|
start_keepalive_thread(session_id)
|
|
end
|
|
end
|
|
|
|
def store_stream_for_session(session_id, stream)
|
|
@mutex.synchronize do
|
|
if @sessions[session_id]
|
|
@sessions[session_id][:stream] = stream
|
|
else
|
|
stream.close
|
|
end
|
|
end
|
|
end
|
|
|
|
def start_keepalive_thread(session_id)
|
|
Thread.new do
|
|
while session_active_with_stream?(session_id)
|
|
sleep(30)
|
|
send_keepalive_ping(session_id)
|
|
end
|
|
rescue StandardError => e
|
|
MCP.configuration.exception_reporter.call(e, { session_id: session_id })
|
|
ensure
|
|
cleanup_session(session_id)
|
|
end
|
|
end
|
|
|
|
def session_active_with_stream?(session_id)
|
|
@mutex.synchronize { @sessions.key?(session_id) && @sessions[session_id][:stream] }
|
|
end
|
|
|
|
def send_keepalive_ping(session_id)
|
|
@mutex.synchronize do
|
|
if @sessions[session_id] && @sessions[session_id][:stream]
|
|
send_ping_to_stream(@sessions[session_id][:stream])
|
|
end
|
|
end
|
|
rescue *STREAM_WRITE_ERRORS => e
|
|
MCP.configuration.exception_reporter.call(
|
|
e,
|
|
{ session_id: session_id, error: "Stream closed" },
|
|
)
|
|
raise # Re-raise to exit the keepalive loop
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|