ab4075c8c7
## Motivation and Context This repository does not track Gemfile.lock, so `bundle install` resolves to the latest RuboCop gems. Upgrading rubocop-shopify from 2.x to 3.0.0 surfaces 8 new offenses because the shared config no longer disables `Style/MutableConstant`, newly disables `Lint/RescueException` and `Naming/AccessorMethodName`, and drops `AllowedPatterns` for `Naming/MethodName`. Upgrading rubocop itself to 1.88 surfaces one more offense from the new `Style/ReduceToHash` cop. This change fixes them as follows: - Freeze mutable constants. Regexp constants are also flagged because `TargetRubyVersion` is 2.7, where Regexp literals are not frozen. - Remove inline disable directives that became redundant. - Restore `AllowedPatterns: ['\Atest_']` for `Naming/MethodName` so `def test_` style test names can reference class names such as `NoMethodError`. - Swap out the frozen `SUPPORTED_STABLE_PROTOCOL_VERSIONS` constant in the protocol version fallback test since Mocha cannot stub methods on frozen objects. - Use `to_h` instead of `each_with_object` in `Server#index_resources_by_uri`. Ref: https://rubygems.org/gems/rubocop-shopify/versions/3.0.0 ## How Has This Been Tested? `bundle exec rake` passes: 1402 runs, 0 failures, 0 errors, and RuboCop reports no offenses. The conformance suite also passes against its baseline. ## Breaking Changes None. Freezing these constants only affects code that mutates them in place, which has never been supported.
22 lines
554 B
Ruby
22 lines
554 B
Ruby
# frozen_string_literal: true
|
|
|
|
module MCP
|
|
class Icon
|
|
SUPPORTED_THEMES = ["light", "dark"].freeze
|
|
|
|
attr_reader :mime_type, :sizes, :src, :theme
|
|
|
|
def initialize(mime_type: nil, sizes: nil, src: nil, theme: nil)
|
|
raise ArgumentError, 'The value of theme must specify "light" or "dark".' if theme && !SUPPORTED_THEMES.include?(theme)
|
|
|
|
@mime_type = mime_type
|
|
@sizes = sizes
|
|
@src = src
|
|
@theme = theme
|
|
end
|
|
|
|
def to_h
|
|
{ mimeType: mime_type, sizes: sizes, src: src, theme: theme }.compact
|
|
end
|
|
end
|
|
end
|