fix: bound streamable HTTP memory usage (#970)

* fix: bound streamable HTTP memory usage

* fix: handle SSE comment lines safely

* refactor: narrow SSE limit public API surface
This commit is contained in:
Dale Seo 2026-07-14 15:05:07 -04:00 • committed by GitHub
commit 24ba5265e2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -39,6 +39,9 @@ use crate::{
},
};
/// Default maximum POST request body size (4 MiB).
pub(crate) const DEFAULT_MAX_REQUEST_BODY_BYTES: usize = 4 * 1024 * 1024;
#[non_exhaustive]
#[derive(Debug, Clone)]
pub struct StreamableHttpServerConfig {
@ -100,6 +103,12 @@ pub struct StreamableHttpServerConfig {
/// };
/// ```
pub session_store: Option<Arc<dyn SessionStore>>,
/// Maximum POST request body size in bytes.
///
/// Enforced while streaming the body, independent of `Content-Length`,
/// chunked transfer encoding, or HTTP version. Oversized payloads receive
/// a `413 Payload Too Large` response.
pub max_request_body_bytes: usize,
}
impl std::fmt::Debug for dyn SessionStore {
@ -119,6 +128,7 @@ impl Default for StreamableHttpServerConfig {
allowed_hosts: vec!["localhost".into(), "127.0.0.1".into(), "::1".into()],
allowed_origins: vec![],
session_store: None,
max_request_body_bytes: DEFAULT_MAX_REQUEST_BODY_BYTES,
}
}
}
@ -172,6 +182,12 @@ impl StreamableHttpServerConfig {
self.cancellation_token = token;
self
}
/// Set the maximum POST request body size in bytes.
pub fn with_max_request_body_bytes(mut self, bytes: usize) -> Self {
self.max_request_body_bytes = bytes;
self
}
}
#[expect(
@ -1141,7 +1157,7 @@ where
// json deserialize request body
let (part, body) = request.into_parts();
let mut message = match expect_json(body).await {
let mut message = match expect_json(body, self.config.max_request_body_bytes).await {
Ok(message) => message,
Err(response) => return Ok(response),
};