fix: remove unnecessary fields from tools' inputSchema (#856)

This commit is contained in:
Federico Poli 2026-05-28 17:28:57 +02:00 • committed by GitHub
commit 53e4410d99
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 114 additions and 10 deletions

View file

@ -91,7 +91,6 @@ fn expected_schema() -> serde_json::Value {
"required": [
"messages"
],
"title": "ChatRequest",
"type": "object"
})
}

View file

@ -0,0 +1,40 @@
#![cfg(all(feature = "server", feature = "macros", not(feature = "local")))]
use rmcp::{
handler::server::wrapper::Parameters,
model::{ListToolsResult, NumberOrString, ServerJsonRpcMessage, ServerResult},
};
/// Parameters for adding two numbers.
#[derive(Debug, serde::Deserialize, schemars::JsonSchema)]
struct AddRequest {
/// The left-hand number.
a: f64,
/// The right-hand number.
b: f64,
}
/// Add two numbers.
#[rmcp::tool]
fn add(Parameters(AddRequest { a, b }): Parameters<AddRequest>) -> String {
(a + b).to_string()
}
#[test]
fn list_tools_result_matches_expected_json() {
let expected_json = std::fs::read("tests/test_list_tools_result/list_tools_result.json")
.expect("missing expected list tools result JSON fixture");
let expected: serde_json::Value =
serde_json::from_slice(&expected_json).expect("invalid expected JSON fixture");
assert_eq!(add(Parameters(AddRequest { a: 1.0, b: 2.0 })), "3");
let result = ListToolsResult::with_all_items(vec![add_tool_attr()]);
let response = ServerJsonRpcMessage::response(
ServerResult::ListToolsResult(result),
NumberOrString::Number(2),
);
let actual = serde_json::to_value(response).expect("failed to serialize list tools response");
assert_eq!(actual, expected);
}

View file

@ -0,0 +1,32 @@
{
"result": {
"tools": [
{
"name": "add",
"description": "Add two numbers.",
"inputSchema": {
"$schema": "https://json-schema.org/draft/2020-12/schema",
"type": "object",
"properties": {
"a": {
"description": "The left-hand number.",
"format": "double",
"type": "number"
},
"b": {
"description": "The right-hand number.",
"format": "double",
"type": "number"
}
},
"required": [
"a",
"b"
]
}
}
]
},
"jsonrpc": "2.0",
"id": 2
}