modelcontextprotocol/rust-sdk
Watch
1
0
Fork
You've already forked rust-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

fix: streamable http server close request channel on response(#266) (#270)

Browse source 
* fix: improve resource unregistration logic in LocalSessionWorker

* fix: fix typo

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This commit is contained in:
4t145 2025-06-19 01:09:36 +08:00 • committed by GitHub
commit 8a577659f0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 11 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

14
crates/rmcp/src/transport/streamable_http_server/session/local.rs
View file

@ -328,11 +328,19 @@ impl LocalSessionWorker {
if let Some(http_request_id) = self.resource_router.remove(resource) { if let Some(http_request_id) = self.resource_router.remove(resource) {
tracing::trace!(?resource, http_request_id, "unregister resource"); tracing::trace!(?resource, http_request_id, "unregister resource");
if let Some(channel) = self.tx_router.get_mut(&http_request_id) { if let Some(channel) = self.tx_router.get_mut(&http_request_id) {
channel.resources.remove(resource); // It's okey to do so, since we don't handle batch json rpc request anymore
if channel.resources.is_empty() { // and this can be refactored after the batch request is removed in the coming version.
if channel.resources.is_empty() || matches!(resource, ResourceKey::McpRequestId(_))
{
tracing::debug!(http_request_id, "close http request wise channel"); tracing::debug!(http_request_id, "close http request wise channel");
self.tx_router.remove(&http_request_id); if let Some(channel) = self.tx_router.remove(&http_request_id) {
for resource in channel.resources {
self.resource_router.remove(&resource);
}
}
} }
} else {
tracing::warn!(http_request_id, "http request wise channel not found");
} }
} }
} }