fix: address 2025-11-25 conformance audit findings (#951)
* fix: interpret task ttl as milliseconds * fix: use text/plain for default text mime type * fix: include resource param in token refresh * test: align conformance prompt args with runner * ci: run server conformance suite on PRs * ci: build client bin and gate pending scenarios
This commit is contained in:
parent
8e44af499b
commit
bdf0c32e8c
1 changed files with 169 additions and 19 deletions
|
|
@ -1687,7 +1687,10 @@ impl AuthorizationManager {
|
|||
debug!("refresh token present, attempting refresh");
|
||||
|
||||
let refresh_token_value = RefreshToken::new(refresh_token.secret().to_string());
|
||||
let mut refresh_request = oauth_client.exchange_refresh_token(&refresh_token_value);
|
||||
let mut refresh_request = oauth_client
|
||||
.exchange_refresh_token(&refresh_token_value)
|
||||
// RFC 8707: the resource indicator is required on token requests, including refreshes
|
||||
.add_extra_param("resource", self.base_url.to_string());
|
||||
let mut refresh_scopes = stored_credentials.granted_scopes;
|
||||
self.add_offline_access_if_supported(&mut refresh_scopes);
|
||||
for scope in refresh_scopes {
|
||||
|
|
@ -5489,6 +5492,42 @@ mod tests {
|
|||
assert_eq!(scope_parts, vec!["read", "write"]);
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn refresh_token_includes_resource_parameter() {
|
||||
let (base_url, captured) = start_token_server().await;
|
||||
|
||||
let mut manager = manager_with_metadata(Some(AuthorizationMetadata {
|
||||
authorization_endpoint: format!("{}/authorize", base_url),
|
||||
token_endpoint: format!("{}/token", base_url),
|
||||
..Default::default()
|
||||
}))
|
||||
.await;
|
||||
manager.configure_client(test_client_config()).unwrap();
|
||||
|
||||
let stored = StoredCredentials {
|
||||
client_id: "my-client".to_string(),
|
||||
token_response: Some(make_token_response_with_refresh(
|
||||
"old-token",
|
||||
"my-refresh-token",
|
||||
)),
|
||||
granted_scopes: vec![],
|
||||
token_received_at: Some(AuthorizationManager::now_epoch_secs()),
|
||||
};
|
||||
manager.credential_store.save(stored).await.unwrap();
|
||||
|
||||
manager.refresh_token().await.unwrap();
|
||||
|
||||
let body = captured.lock().unwrap().take().unwrap();
|
||||
let params: std::collections::HashMap<_, _> = url::form_urlencoded::parse(body.as_bytes())
|
||||
.into_owned()
|
||||
.collect();
|
||||
assert_eq!(
|
||||
params.get("resource").map(String::as_str),
|
||||
Some("http://localhost/"),
|
||||
"refresh requests must carry the RFC 8707 resource parameter, got body: {body}"
|
||||
);
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn refresh_token_adds_offline_access_when_as_supports_it() {
|
||||
let (base_url, captured) = start_token_server().await;
|
||||
|
|
|
|||
Loading…
Reference in a new issue