modelcontextprotocol/rust-sdk
Watch
1
0
Fork
You've already forked rust-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: return a 405 for GET and DELETE if stateful_mode=false (#331)

Browse source
This commit is contained in:
Nate Usher 2025-07-28 11:41:17 -07:00 • committed by GitHub
commit d251800d19
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

15
crates/rmcp/src/transport/streamable_http_server/tower.rs
View file

@ -111,15 +111,20 @@ where
B::Error: Display, B::Error: Display,
{ {
let method = request.method().clone(); let method = request.method().clone();
let result = match method { let allowed_methods = match self.config.stateful_mode {
Method::GET => self.handle_get(request).await, true => "GET, POST, DELETE",
Method::POST => self.handle_post(request).await, false => "POST",
Method::DELETE => self.handle_delete(request).await, };
let result = match (method, self.config.stateful_mode) {
(Method::POST, _) => self.handle_post(request).await,
// if we're not in stateful mode, we don't support GET or DELETE because there is no session
(Method::GET, true) => self.handle_get(request).await,
(Method::DELETE, true) => self.handle_delete(request).await,
_ => { _ => {
// Handle other methods or return an error // Handle other methods or return an error
let response = Response::builder() let response = Response::builder()
.status(http::StatusCode::METHOD_NOT_ALLOWED) .status(http::StatusCode::METHOD_NOT_ALLOWED)
.header(ALLOW, "GET, POST, DELETE") .header(ALLOW, allowed_methods)
.body(Full::new(Bytes::from("Method Not Allowed")).boxed()) .body(Full::new(Bytes::from("Method Not Allowed")).boxed())
.expect("valid response"); .expect("valid response");
return response; return response;