modelcontextprotocol/typescript-sdk
Watch
1
0
Fork
You've already forked typescript-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix sse endpoint path preservation

Browse source
This commit is contained in:
Basil Hosmer 2025-05-16 16:48:31 -04:00
commit 00cb9203cd
No known key found for this signature in database
2 changed files with 4 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/client/sse.test.ts
View file

@ -87,7 +87,7 @@ describe("SSEClientTransport", () => {
await transport.send(message);
// Verify the POST request maintains the custom path
expect(lastServerRequest.url).toBe("/custom/path/messages");
expect(lastServerRequest.url).toBe("/custom/path/sse");
});
it("handles multiple levels of custom paths", async () => {
@ -107,7 +107,7 @@ describe("SSEClientTransport", () => {
await transport.send(message);
// Verify the POST request maintains the full custom path
expect(lastServerRequest.url).toBe("/api/v1/custom/deep/path/messages");
expect(lastServerRequest.url).toBe("/api/v1/custom/deep/path/sse");
});
it("maintains custom path for SSE connection", async () => {
@ -130,7 +130,7 @@ describe("SSEClientTransport", () => {
};
await transport.send(message);
expect(lastServerRequest.url).toBe("/custom/path/messages");
expect(lastServerRequest.url).toBe("/custom/path/sse");
});
it("establishes SSE connection and receives endpoint", async () => {

8
src/client/sse.ts
View file

@ -147,13 +147,7 @@ export class SSEClientTransport implements Transport {
this._endpoint = new URL(messageEvent.data, this._url);
// If the original URL had a custom path, preserve it in the endpoint URL
const originalPath = this._url.pathname;
if (originalPath && originalPath !== '/' && originalPath !== '/sse') {
// Extract the base path from the original URL (everything before the /sse suffix)
const basePath = originalPath.replace(/\/sse$/, '');
// The endpoint should use the same base path but with /messages instead of /sse
this._endpoint.pathname = basePath + '/messages';
}
this._endpoint.pathname = this._url.pathname;
if (this._endpoint.origin !== this._url.origin) {
throw new Error(