modelcontextprotocol/typescript-sdk
Watch
1
0
Fork
You've already forked typescript-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(731): StreamableHTTPClientTransport Fails to Reconnect on Non-Resumable Streams (#732)

Browse source
This commit is contained in:
Jesse 2025-07-15 10:43:02 -06:00 • committed by GitHub
commit 16ea27783c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 127 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

36
src/client/streamableHttp.ts
View file

@ -231,7 +231,7 @@ const response = await (this._fetch ?? fetch)(this._url, {
);
}
this._handleSseStream(response.body, options);
this._handleSseStream(response.body, options, true);
} catch (error) {
this.onerror?.(error as Error);
throw error;
@ -300,7 +300,11 @@ const response = await (this._fetch ?? fetch)(this._url, {
}, delay);
}
private _handleSseStream(stream: ReadableStream<Uint8Array> | null, options: StartSSEOptions): void {
private _handleSseStream(
stream: ReadableStream<Uint8Array> | null,
options: StartSSEOptions,
isReconnectable: boolean,
): void {
if (!stream) {
return;
}
@ -347,20 +351,22 @@ const response = await (this._fetch ?? fetch)(this._url, {
this.onerror?.(new Error(`SSE stream disconnected: ${error}`));
// Attempt to reconnect if the stream disconnects unexpectedly and we aren't closing
if (this._abortController && !this._abortController.signal.aborted) {
if (
isReconnectable &&
this._abortController &&
!this._abortController.signal.aborted
) {
// Use the exponential backoff reconnection strategy
if (lastEventId !== undefined) {
try {
this._scheduleReconnection({
resumptionToken: lastEventId,
onresumptiontoken,
replayMessageId
}, 0);
}
catch (error) {
this.onerror?.(new Error(`Failed to reconnect: ${error instanceof Error ? error.message : String(error)}`));
try {
this._scheduleReconnection({
resumptionToken: lastEventId,
onresumptiontoken,
replayMessageId
}, 0);
}
catch (error) {
this.onerror?.(new Error(`Failed to reconnect: ${error instanceof Error ? error.message : String(error)}`));
}
}
}
}
@ -473,7 +479,7 @@ const response = await (this._fetch ?? fetch)(this._url, init);
// Handle SSE stream responses for requests
// We use the same handler as standalone streams, which now supports
// reconnection with the last event ID
this._handleSseStream(response.body, { onresumptiontoken });
this._handleSseStream(response.body, { onresumptiontoken }, false);
} else if (contentType?.includes("application/json")) {
// For non-streaming servers, we might get direct JSON responses
const data = await response.json();