modelcontextprotocol/typescript-sdk
Watch
1
0
Fork
You've already forked typescript-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

rollback path preservation fix

Browse source
This commit is contained in:
Basil Hosmer 2025-05-16 17:45:44 -04:00
commit 82f5f70924
No known key found for this signature in database
2 changed files with 0 additions and 70 deletions
Download patch file Download diff file Expand all files Collapse all files

65
src/client/sse.test.ts
View file

@ -68,71 +68,6 @@ describe("SSEClientTransport", () => {
});
describe("connection handling", () => {
it("maintains custom path when constructing endpoint URL", async () => {
// Create a URL with a custom path
const customPathUrl = new URL("/custom/path/sse", baseUrl);
transport = new SSEClientTransport(customPathUrl);
// Start the transport
await transport.start();
// Send a test message to verify the endpoint URL
const message: JSONRPCMessage = {
jsonrpc: "2.0",
id: "test-1",
method: "test",
params: {}
};
await transport.send(message);
// Verify the POST request maintains the custom path
expect(lastServerRequest.url).toBe("/custom/path/sse");
});
it("handles multiple levels of custom paths", async () => {
// Test with a deeper nested path
const nestedPathUrl = new URL("/api/v1/custom/deep/path/sse", baseUrl);
transport = new SSEClientTransport(nestedPathUrl);
await transport.start();
const message: JSONRPCMessage = {
jsonrpc: "2.0",
id: "test-1",
method: "test",
params: {}
};
await transport.send(message);
// Verify the POST request maintains the full custom path
expect(lastServerRequest.url).toBe("/api/v1/custom/deep/path/sse");
});
it("maintains custom path for SSE connection", async () => {
const customPathUrl = new URL("/custom/path/sse", baseUrl);
transport = new SSEClientTransport(customPathUrl);
await transport.start();
expect(lastServerRequest.url).toBe("/custom/path/sse");
});
it("handles URLs with query parameters", async () => {
const urlWithQuery = new URL("/custom/path/sse?param=value", baseUrl);
transport = new SSEClientTransport(urlWithQuery);
await transport.start();
const message: JSONRPCMessage = {
jsonrpc: "2.0",
id: "test-1",
method: "test",
params: {}
};
await transport.send(message);
expect(lastServerRequest.url).toBe("/custom/path/sse");
});
it("establishes SSE connection and receives endpoint", async () => {
transport = new SSEClientTransport(baseUrl);
await transport.start();

5
src/client/sse.ts
View file

@ -143,12 +143,7 @@ export class SSEClientTransport implements Transport {
const messageEvent = event as MessageEvent;
try {
// Use the original URL as the base to resolve the received endpoint
this._endpoint = new URL(messageEvent.data, this._url);
// If the original URL had a custom path, preserve it in the endpoint URL
this._endpoint.pathname = this._url.pathname;
if (this._endpoint.origin !== this._url.origin) {
throw new Error(
`Endpoint origin does not match connection origin: ${this._endpoint.origin}`,