modelcontextprotocol/typescript-sdk
Watch
1
0
Fork
You've already forked typescript-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(core): allow additional JSON Schema properties in elicitInput requestedSchema (#1768)

Browse source 
Co-authored-by: Konstantin Konstantinov <KKonstantinov@users.noreply.github.com>
This commit is contained in:
Felix Weinberger 2026-04-02 12:49:58 +01:00 • committed by GitHub
commit 866c08d364
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 40 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
packages/core/src/types/schemas.ts
View file

@ -1861,11 +1861,13 @@ export const ElicitRequestFormParamsSchema = TaskAugmentedRequestParamsSchema.ex
* A restricted subset of JSON Schema.
* Only top-level properties are allowed, without nesting.
*/
requestedSchema: z.object({
type: z.literal('object'),
properties: z.record(z.string(), PrimitiveSchemaDefinitionSchema),
required: z.array(z.string()).optional()
})
requestedSchema: z
.object({
type: z.literal('object'),
properties: z.record(z.string(), PrimitiveSchemaDefinitionSchema),
required: z.array(z.string()).optional()
})
.catchall(z.unknown())
});
/**

28
packages/core/test/types.test.ts
View file

@ -6,6 +6,7 @@ import {
CreateMessageRequestSchema,
CreateMessageResultSchema,
CreateMessageResultWithToolsSchema,
ElicitRequestFormParamsSchema,
LATEST_PROTOCOL_VERSION,
PromptMessageSchema,
ResourceLinkSchema,
@ -983,4 +984,31 @@ describe('Types', () => {
}
});
});
describe('ElicitRequestFormParamsSchema', () => {
test('accepts requestedSchema with extra JSON Schema metadata keys', () => {
// Mirrors what z.toJSONSchema() emits — includes $schema, additionalProperties, etc.
// See https://github.com/modelcontextprotocol/typescript-sdk/issues/1362
const params = {
message: 'Please provide your name',
requestedSchema: {
$schema: 'https://json-schema.org/draft/2020-12/schema',
type: 'object',
properties: {
name: { type: 'string' }
},
required: ['name'],
additionalProperties: false
}
};
const result = ElicitRequestFormParamsSchema.safeParse(params);
expect(result.success).toBe(true);
if (result.success) {
expect(result.data.requestedSchema.type).toBe('object');
expect(result.data.requestedSchema.$schema).toBe('https://json-schema.org/draft/2020-12/schema');
expect(result.data.requestedSchema.additionalProperties).toBe(false);
}
});
});
});