modelcontextprotocol/typescript-sdk
Watch
1
0
Fork
You've already forked typescript-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

make protocol class not overwrite existing hooks when connecting transports

Browse source
This commit is contained in:
Samuel Jensen 2025-05-10 00:51:54 +02:00
commit 9edb619600
1 changed files with 25 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/shared/protocol.test.ts
View file

@ -65,6 +65,22 @@ describe("protocol tests", () => {
expect(oncloseMock).toHaveBeenCalled();
});
test("should not overwrite existing hooks when connecting transports", async () => {
const oncloseMock = jest.fn();
const onerrorMock = jest.fn();
const onmessageMock = jest.fn();
transport.onclose = oncloseMock;
transport.onerror = onerrorMock;
transport.onmessage = onmessageMock;
await protocol.connect(transport);
transport.onclose();
transport.onerror(new Error());
transport.onmessage("");
expect(oncloseMock).toHaveBeenCalled();
expect(onerrorMock).toHaveBeenCalled();
expect(onmessageMock).toHaveBeenCalled();
});
describe("_meta preservation with onprogress", () => {
test("should preserve existing _meta when adding progressToken", async () => {
await protocol.connect(transport);