v2 ESlint fixes (#1403)

Co-authored-by: Matt <77928207+mattzcarey@users.noreply.github.com>

common/eslint-config/eslint.config.mjs

@@ -8,6 +8,7 @@ import eslintConfigPrettier from 'eslint-config-prettier/flat';
 import importPlugin from 'eslint-plugin-import';
 import nodePlugin from 'eslint-plugin-n';
 import simpleImportSortPlugin from 'eslint-plugin-simple-import-sort';
+import eslintPluginUnicorn from 'eslint-plugin-unicorn';
 import { configs } from 'typescript-eslint';
 
 const __dirname = path.dirname(fileURLToPath(import.meta.url));
@@ -17,6 +18,7 @@ export default defineConfig(
     ...configs.recommended,
     importPlugin.flatConfigs.recommended,
     importPlugin.flatConfigs.typescript,
+    eslintPluginUnicorn.configs.recommended,
     {
         languageOptions: {
             parserOptions: {
@@ -42,6 +44,10 @@ export default defineConfig(
             }
         },
         rules: {
+            'unicorn/prevent-abbreviations': 'off',
+            'unicorn/no-null': 'off',
+            'unicorn/prefer-add-event-listener': 'off',
+            'unicorn/no-useless-undefined': ['error', { checkArguments: false }],
             '@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
             'n/prefer-node-protocol': 'error',
             '@typescript-eslint/consistent-type-imports': ['error', { disallowTypeAnnotations: false }],
@@ -64,6 +70,12 @@ export default defineConfig(
                     optionalDependencies: false,
                     peerDependencies: true
                 }
+            ],
+            'unicorn/filename-case': [
+                'error',
+                {
+                    case: 'camelCase'
+                }
             ]
         }
     },

common/eslint-config/package.json

@@ -29,6 +29,7 @@
         "eslint-plugin-import": "^2.32.0",
         "eslint-plugin-n": "catalog:devTools",
         "eslint-plugin-simple-import-sort": "^12.1.1",
+        "eslint-plugin-unicorn": "^62.0.0",
         "prettier": "catalog:devTools",
         "typescript": "catalog:devTools",
         "typescript-eslint": "catalog:devTools"

common/vitest-config/vitest.config.js

@@ -14,7 +14,7 @@ export default defineConfig({
         exclude: ignorePatterns,
         deps: {
             moduleDirectories: ['node_modules', path.resolve(__dirname, '../../packages'), path.resolve(__dirname, '../../common')]
-        },
+        }
     },
     poolOptions: {
         threads: {