modelcontextprotocol/typescript-sdk
Watch
1
0
Fork
You've already forked typescript-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Merge pull request #68 from modelcontextprotocol/ani/fix-npx

Browse source 
Fix npx and other processes that launch subprocesses
This commit is contained in:
Ani Betts 2024-11-26 15:43:45 +01:00 • committed by GitHub
commit d5c0e86664
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/client/stdio.ts
View file

@ -100,7 +100,7 @@ export class StdioClientTransport implements Transport {
async start(): Promise<void> {
if (this._process) {
throw new Error(
"StdioClientTransport already started! If using Client class, note that connect() calls start() automatically.",
"StdioClientTransport already started! If using Client class, note that connect() calls start() automatically."
);
}
@ -113,17 +113,8 @@ export class StdioClientTransport implements Transport {
stdio: ["pipe", "pipe", this._serverParams.stderr ?? "inherit"],
shell: false,
signal: this._abortController.signal,
// NB: The behavior of detached varies based on platform, and also
// is different based on whether the process is a Win32 Subsystem
// process or a Console Subsystem process. Strangely, the behavior
// of detached is almost 1:1 the opposite in Electron+Windows vs
// what is documented on the node.js website, and also is different
// based on whether you launch Electron in a development environment
// (i.e. via `electron-forge start`) vs a production environment
// (i.e. YourApp.exe).
detached: process.platform === "win32" && isElectron(),
},
windowsHide: process.platform === "win32" && isElectron(),
}
);
this._process.on("error", (error) => {