modelcontextprotocol/typescript-sdk
Watch
1
0
Fork
You've already forked typescript-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Special-case this fix to Electron apps

Browse source
This commit is contained in:
Anaïs Betts 2024-11-20 15:54:13 +01:00
commit e0c821cad9
No known key found for this signature in database
1 changed files with 15 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/client/stdio.ts
View file

@ -112,9 +112,18 @@ export class StdioClientTransport implements Transport {
env: this._serverParams.env ?? getDefaultEnvironment(),
stdio: ["pipe", "pipe", this._serverParams.stderr ?? "inherit"],
shell: false,
detached: process.platform === "win32",
signal: this._abortController.signal,
},
// NB: The behavior of detached varies based on platform, and also
// is different based on whether the process is a Win32 Subsystem
// process or a Console Subsystem process. Strangely, the behavior
// of detached is almost 1:1 the opposite in Electron+Windows vs
// what is documented on the node.js website, and also is different
// based on whether you launch Electron in a development environment
// (i.e. via `electron-forge start`) vs a production environment
// (i.e. YourApp.exe).
detached: process.platform === "win32" && isElectron(),
}
);
this._process.on("error", (error) => {
@ -188,3 +197,7 @@ export class StdioClientTransport implements Transport {
});
}
}
function isElectron() {
return "type" in process;
}