modelcontextprotocol/csharp-sdk
Watch
1
0
Fork
You've already forked csharp-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix race condition in AutomaticInputRequiredStatusTests polling logic (#1223)

Browse source 
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ericstj <8918108+ericstj@users.noreply.github.com>
Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
This commit is contained in:
Copilot 2026-01-30 15:21:28 -05:00 • committed by GitHub
commit 283caf9810
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tests/ModelContextProtocol.Tests/Server/AutomaticInputRequiredStatusTests.cs
View file

@ -119,7 +119,7 @@ public class AutomaticInputRequiredStatusTests : LoggedTest
finalStatus = await taskStore.GetTaskAsync(mcpTask.TaskId, cancellationToken: TestContext.Current.CancellationToken); finalStatus = await taskStore.GetTaskAsync(mcpTask.TaskId, cancellationToken: TestContext.Current.CancellationToken);
maxAttempts--; maxAttempts--;
} }
while (finalStatus?.Status == McpTaskStatus.Working && maxAttempts > 0); while (finalStatus?.Status is not McpTaskStatus.Completed && maxAttempts > 0);
// Assert - Status should have been InputRequired during sampling // Assert - Status should have been InputRequired during sampling
Assert.Contains(McpTaskStatus.InputRequired, statusesDuringSampling); Assert.Contains(McpTaskStatus.InputRequired, statusesDuringSampling);
@ -218,7 +218,7 @@ public class AutomaticInputRequiredStatusTests : LoggedTest
finalStatus = await taskStore.GetTaskAsync(mcpTask.TaskId, cancellationToken: TestContext.Current.CancellationToken); finalStatus = await taskStore.GetTaskAsync(mcpTask.TaskId, cancellationToken: TestContext.Current.CancellationToken);
maxAttempts--; maxAttempts--;
} }
while (finalStatus?.Status == McpTaskStatus.Working && maxAttempts > 0); while (finalStatus?.Status is not McpTaskStatus.Completed && maxAttempts > 0);
// Assert - Status should have been InputRequired during elicitation // Assert - Status should have been InputRequired during elicitation
Assert.Contains(McpTaskStatus.InputRequired, statusesDuringElicitation); Assert.Contains(McpTaskStatus.InputRequired, statusesDuringElicitation);