* perf(pdf-server): lazy form extraction via range transport + incremental viewer scans Server: display_pdf now opens the document via PDFDataRangeTransport (disableAutoFetch) and only runs the per-page form/annotation walk when getFieldObjects() is non-empty, so form-free PDFs are probed with ~10-25% of bytes instead of a full download. The unused viewFieldInfo Map is removed. Viewer: getDocument sets disableAutoFetch/disableStream; baseline annotation scan and field-name mapping run lazily per rendered page instead of walking every page after load, so first paint no longer schedules a full-file pull. E2E: new range-counting HTTPS fixture (W-9 for forms, generated text+image PDF for no-forms) with stallAfterBytes control, and four regression tests asserting form fields are returned, <30% served on no-forms display_pdf, first page renders while later ranges are stalled, and overlap stays bounded. * fix(pdf-server): handle separated field/widget trees in extractFormSchema pdfjs getFieldObjects() returns the full field-tree array. For PDFs with a separated structure (pdf-lib, some authoring tools) the typed widget sits at fields[1+] behind a typeless container at fields[0]; the previous code only inspected fields[0] and skipped them all. Pick the first entry with a non-empty type instead. Makes the e2e forms.pdf fixture fully generated (no checked-in third-party asset on the hot path); fw9.pdf stays as a unit-test fixture for the hierarchical/XFA case. * fix(pdf-server): address range-transport hangs and lazy-scan tombstone loss PdfCacheRangeTransport: - abort() is a no-op stub on PDFDataRangeTransport (it's the hook pdfjs calls *on* the transport, not an upstream error channel). Expose a .failed promise that rejects on the first fetch error and race every pdfjs await against it in display_pdf, so transient network errors surface into the existing catch instead of hanging the tool call. - pdfjs coalesces adjacent missing chunks into one unbounded requestDataRange; readPdfRange clamps each call to MAX_CHUNK_BYTES. Loop and deliver in slices so every requested chunk is marked loaded. Viewer (mcp-app.ts): - The lazy per-page baseline scan left pdfBaselineAnnotations incomplete, so persistAnnotations and getAnnotatedPdfBytes silently dropped restoredRemovedIds tombstones for unvisited pages. Union those ids into the computed diff and removedRefs. Test fixture: release stalled handlers before resetStats/close so a failing stalled test doesn't hang afterAll; fail fast if started with NODE_ENV=production. NODE_TLS_REJECT_UNAUTHORIZED scope documented (full per-process scoping needs a validateUrl localhost allow, tracked separately). * test(pdf-server): bridge coverage gaps and switch fixture to gated loopback HTTP PdfCacheRangeTransport.deliver(): pdf.js's reader is keyed by the original begin and removed after one delivery, so accumulate slices and call onDataRange once with the full buffer (the previous multi-call approach threw inside pdfjs). Covered by a new integration test that drives getDocument()/getPage(1) on a >1MB PDF through a clamping in-memory readPdfRange. validateUrl: allow http://127.0.0.1|localhost|[::1] only when PDF_SERVER_ALLOW_LOOPBACK_HTTP is set, so a remote deploy can't be made to probe its own ports. Covered by env-on/off unit tests. Fixture switched to plain HTTP (no openssl, no NODE_TLS_REJECT_UNAUTHORIZED). Adds /error.pdf (500s after 50KB) and two e2e tests: page 2 renders after stall release (>512KB object path), and display_pdf returns gracefully on mid-load 500. Existing <30% test now samples stats before the iframe loads. New unit tests: display_pdf returns (not hangs) on mid-load fetch failure via in-memory MCP client; computeDiff/serializeDiff contract tests pinning the restoredRemovedIds tombstone-preservation behaviour. * test(pdf-server): e2e for restoredRemovedIds tombstone preservation through viewer Adds /with-native-annot.pdf fixture (2 pages, native /Text annot on page 2) and a Playwright test that drives delete on page 2 → iframe reload → interact add_annotations on page 1 (persist with page 2 unscanned) → assert localStorage diff still contains the removed id → page 2 still shows it gone. Covers the mcp-app.ts glue the unit tests can't reach. * refactor(pdf-server): simplify per round-2 review and fix false-pass test server.ts: extract probeFormFields() so display_pdf calls one helper instead of inlining 40 lines of transport/orFail plumbing; make extractFormSchema's fieldObjects param required (the optional branch only existed for a test helper). server.test.ts: the >1MB integration test now forces the image XObject fetch via getOperatorList() and asserts max requestDataRange span > MAX_CHUNK_BYTES, so it can't go vacuous. Dedupe makeRandomJpeg by importing from the fixture. mcp-app.ts: restore per-annotation try/catch isolation in the lazy baseline scan (a throw was skipping AnnotationLayer.render); only carry forward restoredRemovedIds while the baseline scan is incomplete so a stale id can't pin dirty=true once every page is scanned. tests: bump fixture JPEG to 1.1MB; consolidate 7 e2e tests to 4 (merge overlap into the byte-budget test, merge stall+page-2, drop the error-e2e duplicate of the unit integration test); delete run-fixture.mjs; drop /error.pdf and ERROR_AFTER_BYTES; rename tombstone test's describe and clarify page-2 covers the viewer transport. * fix(pdf-server): preserve partial probeFormFields results when extractFormFieldInfo throws * test(pdf-server): fix tombstone e2e — deleted native annotations become a cleared card, not removed from DOM * test(pdf-server): mark tombstone e2e as fixme — needs basic-host iframe-reload replay support * test(pdf-server): link tombstone fixme to tracking issue #642
249 lines
8.4 KiB
TypeScript
249 lines
8.4 KiB
TypeScript
/**
|
|
* HTTP test fixture serving programmatically-generated PDFs with byte-range
|
|
* accounting. Used by pdf-incremental-load.spec.ts to assert that display_pdf
|
|
* doesn't pull the whole file before the viewer starts streaming.
|
|
*
|
|
* Plain HTTP on loopback — playwright.config.ts sets
|
|
* PDF_SERVER_ALLOW_LOOPBACK_HTTP=1 so validateUrl accepts http://127.0.0.1.
|
|
*/
|
|
import http from "node:http";
|
|
import type { AddressInfo } from "node:net";
|
|
import { PDFDocument, PDFName, PDFString, StandardFonts } from "pdf-lib";
|
|
|
|
export interface RangeServerStats {
|
|
/** Total bytes written across all responses (sum of slice lengths). */
|
|
totalBytesServed: number;
|
|
/** Bytes that were served more than once for the same path. */
|
|
overlapBytes: number;
|
|
}
|
|
|
|
export interface RangeServer {
|
|
port: number;
|
|
baseUrl: string;
|
|
/** Map of served path → byte length. */
|
|
fileSizes: Record<string, number>;
|
|
stats(): RangeServerStats;
|
|
resetStats(): void;
|
|
/** Resolve any requests currently stalled by ?stallAfterBytes=N. */
|
|
release(): void;
|
|
close(): Promise<void>;
|
|
}
|
|
|
|
const LOREM =
|
|
"Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed do eiusmod " +
|
|
"tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim " +
|
|
"veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea " +
|
|
"commodo consequat. ";
|
|
|
|
async function buildNoFormsPdf(): Promise<Uint8Array> {
|
|
const doc = await PDFDocument.create();
|
|
const font = await doc.embedFont(StandardFonts.Helvetica);
|
|
// Page 1 is text-only (small) so first paint needs minimal bytes. Pages 2+
|
|
// each reference a large embedded JPEG so the bulk of the file is in image
|
|
// streams page 1 doesn't need. The stallAfterBytes test holds those back
|
|
// and asserts page 1 still renders. The image is >MAX_CHUNK_BYTES (512KB)
|
|
// so rendering page 2 also exercises the viewer's >512KB range path.
|
|
const big = await doc.embedJpg(makeRandomJpeg(1_100 * 1024));
|
|
const page1 = doc.addPage([612, 792]);
|
|
for (let line = 0; line < 30; line++) {
|
|
page1.drawText(`1.${line + 1} ${LOREM}`, {
|
|
x: 36,
|
|
y: 760 - line * 22,
|
|
size: 10,
|
|
font,
|
|
});
|
|
}
|
|
for (let p = 1; p < 20; p++) {
|
|
const page = doc.addPage([612, 792]);
|
|
page.drawImage(big, { x: 36, y: 200, width: 540, height: 540 });
|
|
page.drawText(`Page ${p + 1}`, { x: 36, y: 760, size: 10, font });
|
|
}
|
|
return doc.save();
|
|
}
|
|
|
|
/** Minimal valid JPEG with `len` bytes of incompressible scan data. */
|
|
export function makeRandomJpeg(len: number): Uint8Array {
|
|
// SOI, APP0 (JFIF), SOF0 (baseline 8x8 1-component), DHT (minimal),
|
|
// SOS, <random scan data>, EOI. pdf-lib only needs to parse the headers
|
|
// to embed; the scan data is opaque.
|
|
const header = Uint8Array.from([
|
|
0xff, 0xd8, 0xff, 0xe0, 0x00, 0x10, 0x4a, 0x46, 0x49, 0x46, 0x00, 0x01,
|
|
0x01, 0x00, 0x00, 0x01, 0x00, 0x01, 0x00, 0x00, 0xff, 0xc0, 0x00, 0x0b,
|
|
0x08, 0x00, 0x08, 0x00, 0x08, 0x01, 0x01, 0x11, 0x00, 0xff, 0xc4, 0x00,
|
|
0x14, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
|
|
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0xda, 0x00, 0x08, 0x01,
|
|
0x01, 0x00, 0x00, 0x3f, 0x00,
|
|
]);
|
|
const scan = new Uint8Array(len);
|
|
for (let i = 0; i < len; i++) scan[i] = (i * 1103515245 + 12345) & 0xff;
|
|
// Avoid 0xFF in scan data so we don't accidentally form a marker.
|
|
for (let i = 0; i < len; i++) if (scan[i] === 0xff) scan[i] = 0xfe;
|
|
const eoi = Uint8Array.from([0xff, 0xd9]);
|
|
const out = new Uint8Array(header.length + scan.length + eoi.length);
|
|
out.set(header, 0);
|
|
out.set(scan, header.length);
|
|
out.set(eoi, header.length + scan.length);
|
|
return out;
|
|
}
|
|
|
|
/**
|
|
* Two pages, page 1 text-only, page 2 carries one native /Text (sticky-note)
|
|
* annotation. Used by the tombstone-preservation e2e: the viewer's lazy
|
|
* baseline scan must not have visited page 2 when persistAnnotations runs.
|
|
*/
|
|
async function buildWithNativeAnnotPdf(): Promise<Uint8Array> {
|
|
const doc = await PDFDocument.create();
|
|
const font = await doc.embedFont(StandardFonts.Helvetica);
|
|
const page1 = doc.addPage([612, 792]);
|
|
page1.drawText("Page 1 — no native annotations here.", {
|
|
x: 36,
|
|
y: 740,
|
|
size: 12,
|
|
font,
|
|
});
|
|
const page2 = doc.addPage([612, 792]);
|
|
page2.drawText("Page 2 — has one native /Text annot.", {
|
|
x: 36,
|
|
y: 740,
|
|
size: 12,
|
|
font,
|
|
});
|
|
const annotRef = doc.context.register(
|
|
doc.context.obj({
|
|
Type: "Annot",
|
|
Subtype: "Text",
|
|
Rect: [100, 700, 120, 720],
|
|
Contents: PDFString.of("native sticky note"),
|
|
Open: false,
|
|
Name: "Comment",
|
|
}),
|
|
);
|
|
page2.node.set(PDFName.of("Annots"), doc.context.obj([annotRef]));
|
|
return doc.save();
|
|
}
|
|
|
|
async function buildFormsPdf(): Promise<Uint8Array> {
|
|
const doc = await PDFDocument.create();
|
|
const form = doc.getForm();
|
|
for (let p = 0; p < 2; p++) doc.addPage([612, 792]);
|
|
const [page1] = doc.getPages();
|
|
const fields = ["name", "email", "phone", "city", "notes"];
|
|
fields.forEach((name, i) => {
|
|
const f = form.createTextField(name);
|
|
f.addToPage(page1, { x: 100, y: 650 - i * 60, width: 300, height: 24 });
|
|
});
|
|
return doc.save();
|
|
}
|
|
|
|
export async function startRangeServer(): Promise<RangeServer> {
|
|
if (process.env.NODE_ENV === "production") {
|
|
throw new Error(
|
|
"range-counting-server is a test fixture; refusing to start with NODE_ENV=production",
|
|
);
|
|
}
|
|
const files: Record<string, Uint8Array> = {
|
|
"/noforms.pdf": await buildNoFormsPdf(),
|
|
"/forms.pdf": await buildFormsPdf(),
|
|
"/with-native-annot.pdf": await buildWithNativeAnnotPdf(),
|
|
};
|
|
const fileSizes = Object.fromEntries(
|
|
Object.entries(files).map(([k, v]) => [k, v.length]),
|
|
);
|
|
|
|
// Per-path hit count per byte, for overlap accounting.
|
|
const hitCounts: Record<string, Uint8Array> = {};
|
|
const initHits = () => {
|
|
for (const [k, v] of Object.entries(files)) {
|
|
hitCounts[k] = new Uint8Array(v.length);
|
|
}
|
|
};
|
|
initHits();
|
|
|
|
let totalBytesServed = 0;
|
|
let releaseResolve: (() => void) | undefined;
|
|
let releasePromise = new Promise<void>((r) => (releaseResolve = r));
|
|
|
|
const server = http.createServer(async (req, res) => {
|
|
const url = new URL(req.url ?? "/", "http://127.0.0.1");
|
|
const body = files[url.pathname];
|
|
if (!body) {
|
|
res.writeHead(404).end();
|
|
return;
|
|
}
|
|
|
|
const stallAfterBytes = url.searchParams.get("stallAfterBytes");
|
|
const total = body.length;
|
|
const range = req.headers.range;
|
|
|
|
let begin = 0;
|
|
let end = total; // exclusive
|
|
let status = 200;
|
|
if (range) {
|
|
const m = /^bytes=(\d+)-(\d*)$/.exec(range);
|
|
if (m) {
|
|
begin = parseInt(m[1], 10);
|
|
end = m[2] ? parseInt(m[2], 10) + 1 : total;
|
|
begin = Math.min(begin, total);
|
|
end = Math.min(end, total);
|
|
status = 206;
|
|
}
|
|
}
|
|
|
|
// Stall once N bytes have already been served — lets pdfjs read the
|
|
// header/trailer/xref (scattered across the file) before blocking the
|
|
// bulk content streams.
|
|
if (stallAfterBytes !== null) {
|
|
if (totalBytesServed >= parseInt(stallAfterBytes, 10)) {
|
|
await releasePromise;
|
|
}
|
|
}
|
|
|
|
const slice = body.subarray(begin, end);
|
|
totalBytesServed += slice.length;
|
|
const hits = hitCounts[url.pathname];
|
|
for (let i = begin; i < end; i++) hits[i]++;
|
|
|
|
const headers: Record<string, string> = {
|
|
"Content-Type": "application/pdf",
|
|
"Accept-Ranges": "bytes",
|
|
"Content-Length": String(slice.length),
|
|
};
|
|
if (status === 206) {
|
|
headers["Content-Range"] = `bytes ${begin}-${end - 1}/${total}`;
|
|
}
|
|
res.writeHead(status, headers);
|
|
res.end(slice);
|
|
});
|
|
|
|
await new Promise<void>((resolve) => server.listen(0, resolve));
|
|
const port = (server.address() as AddressInfo).port;
|
|
|
|
return {
|
|
port,
|
|
baseUrl: `http://127.0.0.1:${port}`,
|
|
fileSizes,
|
|
stats() {
|
|
let overlapBytes = 0;
|
|
for (const hits of Object.values(hitCounts)) {
|
|
for (let i = 0; i < hits.length; i++) if (hits[i] > 1) overlapBytes++;
|
|
}
|
|
return { totalBytesServed, overlapBytes };
|
|
},
|
|
resetStats() {
|
|
totalBytesServed = 0;
|
|
initHits();
|
|
// Unblock any handlers parked on the previous stall before re-arming,
|
|
// otherwise they hold sockets open forever and close() hangs.
|
|
releaseResolve?.();
|
|
releasePromise = new Promise<void>((r) => (releaseResolve = r));
|
|
},
|
|
release() {
|
|
releaseResolve?.();
|
|
},
|
|
close() {
|
|
releaseResolve?.();
|
|
server.closeAllConnections?.();
|
|
return new Promise<void>((resolve) => server.close(() => resolve()));
|
|
},
|
|
};
|
|
}
|