John Howard
b012d0824e
client: allow re-using connections in more cases ...
I am seeing a bug where connections with a Streamable HTTP client are
not reused at all. This makes performance terrible, since each request
establishes a new TCP connection.
I was able to root cause this down to behavior of the `processStream`
function. This sets up a bufio.NewScanner, and waits to get data. Once
we get a message, we abort and *close the connection*.
At this point, there are two paths:
* The bufio reader read the *full* response body to EOF, and then we
closed. This case is fine; we can re-use the idle connection.
* The bufio reader *did not* real the full response body. It may have
read the entire actual data that *would be sent*, but since its
streaming happened to not yet be delivered. In this case, we call
`body.Close()` before an EOF, which causes the HTTP client to not
attempt to re-use the connection.
In my case, the server I am using reliable sends the response over 2 TCP
packets (one with the event, and the other with the closure of the
`chunked` encoding (`0`)). This causes the body to never be fully read.
This PR fixes that case by unconditionally reading the full body before
we close the connection. With this change, I am able to reliably re-use
connections for future requests.
2025-12-10 17:06:20 -05:00
Implement SEP-973 ( #570 )
2025-11-12 16:52:44 -05:00
mcp: gate prime and close events on protocol version 2025-11-25 ( #696 )
2025-12-08 15:24:41 -05:00
mcp: fix goroutine leaks in unit tests ( #496 )
2025-10-16 11:13:30 -04:00
mcp: allow any value for schemas ( #517 )
2025-09-26 11:55:54 -04:00
all: expose JSON-RPC error codes, and support URLElicitationRequired errors ( #655 )
2025-12-01 11:29:17 -05:00
mcp: speed up TestCommandTransportDuration
2025-09-12 12:00:29 -04:00
mcp: speed up TestCommandTransportDuration
2025-09-12 12:00:29 -04:00
mcp: fix goroutine leaks in unit tests ( #496 )
2025-10-16 11:13:30 -04:00
internal/mcp: update protocol versions
2025-06-18 08:11:16 -07:00
internal/mcp: update protocol versions
2025-06-18 08:11:16 -07:00
Implement SEP-973 ( #570 )
2025-11-12 16:52:44 -05:00
Implement SEP-973 ( #570 )
2025-11-12 16:52:44 -05:00
mcp: add CallToolResult.getError ( #481 )
2025-09-18 08:08:23 -04:00
Implement SEP-973 ( #570 )
2025-11-12 16:52:44 -05:00
all: expose JSON-RPC error codes, and support URLElicitationRequired errors ( #655 )
2025-12-01 11:29:17 -05:00
all: expose JSON-RPC error codes, and support URLElicitationRequired errors ( #655 )
2025-12-01 11:29:17 -05:00
mcp: support SSE polling and server disconnects (SEP-1699) ( #663 )
2025-12-01 16:21:37 -05:00
mcp: remove the StreamID type ( #490 )
2025-09-18 12:01:07 -04:00
mcp: minor cleanup of some TODOs ( #332 )
2025-08-20 12:55:19 -04:00
mcp: change tool handler design ( #325 )
2025-08-20 19:36:34 -04:00
mcp/server: enable server logging ( #501 )
2025-10-02 14:44:32 -04:00
mcp: fix inaccurate package doc ( #534 )
2025-09-26 14:16:10 -04:00
docs: add feature and troubleshooting documentation ( #463 )
2025-09-16 11:13:40 -04:00
mcp/mcp_test: tests for elicit content validation ( #676 )
2025-12-03 10:12:07 -05:00
mcp: align PromptHandler args with other handlers ( #348 )
2025-08-22 10:44:05 -04:00
mcp: support url mode elicitation ( #646 )
2025-11-23 12:58:28 -05:00
mcp: add CallToolResult.getError ( #481 )
2025-09-18 08:08:23 -04:00
mcp: support url mode elicitation ( #646 )
2025-11-23 12:58:28 -05:00
all: expose JSON-RPC error codes, and support URLElicitationRequired errors ( #655 )
2025-12-01 11:29:17 -05:00
internal/mcp: add the FileResourceHandler method
2025-05-19 11:15:23 -07:00
internal/mcp: add the FileResourceHandler method
2025-05-19 11:15:23 -07:00
mcp/Resource: Refactor URI Template Matching with uritemplate Library ( #100 )
2025-07-08 15:52:54 -04:00
all: expose JSON-RPC error codes, and support URLElicitationRequired errors ( #655 )
2025-12-01 11:29:17 -05:00
doc: document logging ( #497 )
2025-09-19 11:58:58 -04:00
mcp: validate tool names ( #640 )
2025-11-19 17:01:50 -05:00
mcp: support stateless streamable sessions ( #277 )
2025-08-11 16:43:46 -04:00
mcp: clarify documentation for the streamable transports
2025-12-10 10:46:10 -05:00
all: remove ServerRequest[T] for concrete T ( #342 )
2025-08-21 12:10:53 -04:00
SSE: Add support for SSE handler options ( #508 )
2025-09-19 13:01:57 -04:00
SSE: Add support for SSE handler options ( #508 )
2025-09-19 13:01:57 -04:00
SSE: Add support for SSE handler options ( #508 )
2025-09-19 13:01:57 -04:00
client: allow re-using connections in more cases
2025-12-10 17:06:20 -05:00
mcp: don't persist failed streamable sessions ( #605 )
2025-10-27 16:29:16 -04:00
mcp: clarify documentation for the streamable transports
2025-12-10 10:46:10 -05:00
mcp: better handling for streamable context cancellation ( #677 )
2025-12-03 12:26:50 -05:00
mcp: fix goroutine leaks in unit tests ( #496 )
2025-10-16 11:13:30 -04:00
mcp: simplify stream state management in streamable transport
2025-12-10 13:28:25 -05:00
mcp: gate prime and close events on protocol version 2025-11-25 ( #696 )
2025-12-08 15:24:41 -05:00
mcp: validate tool names ( #640 )
2025-11-19 17:01:50 -05:00
mcp: allow any value for schemas ( #517 )
2025-09-26 11:55:54 -04:00
all: expose JSON-RPC error codes, and support URLElicitationRequired errors ( #655 )
2025-12-01 11:29:17 -05:00
mcp: better handling for streamable context cancellation ( #677 )
2025-12-03 12:26:50 -05:00
mcp: fix goroutine leaks in unit tests ( #496 )
2025-10-16 11:13:30 -04:00
fix: handle Windows CRLF in MCP client( #664 ) ( #665 )
2025-12-01 12:16:39 -05:00
mcp: allow any value for schemas ( #517 )
2025-09-26 11:55:54 -04:00
b012d0824e