modelcontextprotocol/inspector
Watch
1
0
Fork
You've already forked inspector
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

docs: correct the saveClientInformation contract comment

Browse source 
Copilot review (#2287, suppressed comment): the comment still said internal
callers supply no issuer, which stopped being true when
ensureCimdClientRegistration started binding its save to the discovered issuer.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lmj6X2epWpPE7ScdSKQmtA
Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
cliffhall 2026-09-07 01:35:03 -04:00
commit 4350731f36
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
core/auth/providers.ts
View file

@ -293,9 +293,12 @@ export class BaseOAuthClientProvider implements OAuthClientProvider {
// SDK v2's `OAuthClientProvider.saveClientInformation` passes an // SDK v2's `OAuthClientProvider.saveClientInformation` passes an
// `OAuthClientInformationContext` ({ issuer }); our own DCR/CIMD callers // `OAuthClientInformationContext` ({ issuer }); our own DCR/CIMD callers
// pass `SaveClientInformationOptions` ({ registrationKind }). Accept either // pass `SaveClientInformationOptions` ({ registrationKind }). Accept either
// and read whichever keys are present: the SDK supplies `issuer` (SEP-2352 // and read whichever keys are present. The SDK supplies `issuer` (SEP-2352
// per-AS keying) and no kind — `resolveSdkRegistrationKind` recovers it — // per-AS keying) and never a kind, so `resolveSdkRegistrationKind` recovers
// while our callers supply the registration kind and no issuer yet. // one. Our own callers always supply the kind, and supply the `issuer` too
// when they know it — `ensureCimdClientRegistration` does, having just
// discovered it; the unkeyed slot is only for the case where AS metadata
// carried no `issuer` at all.
options?: SaveClientInformationOptions | OAuthClientInformationContext, options?: SaveClientInformationOptions | OAuthClientInformationContext,
): Promise<void> { ): Promise<void> {
const issuer = options && "issuer" in options ? options.issuer : undefined; const issuer = options && "issuer" in options ? options.issuer : undefined;