Address PR #1214 review nits
- Hoist previewUri() to a const in ResourceTemplatePanel to avoid duplicate computation - Include resource.title in subscriptions search filter for consistency with resources and templates filters Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
8c9aac6df1
commit
995c06948c
2 changed files with 5 additions and 2 deletions
|
|
@ -70,6 +70,7 @@ export function ResourceControls({
|
||||||
const filteredSubscriptions = subscriptions.filter(
|
const filteredSubscriptions = subscriptions.filter(
|
||||||
(s) =>
|
(s) =>
|
||||||
s.resource.name.toLowerCase().includes(query) ||
|
s.resource.name.toLowerCase().includes(query) ||
|
||||||
|
(s.resource.title?.toLowerCase().includes(query) ?? false) ||
|
||||||
s.resource.uri.toLowerCase().includes(query),
|
s.resource.uri.toLowerCase().includes(query),
|
||||||
);
|
);
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -91,13 +91,15 @@ export function ResourceTemplatePanel({
|
||||||
onReadResource(resolveUri(uriTemplate, variables));
|
onReadResource(resolveUri(uriTemplate, variables));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
const preview = previewUri(uriTemplate, variables);
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<Stack gap="md">
|
<Stack gap="md">
|
||||||
<HeaderRow>
|
<HeaderRow>
|
||||||
<Title order={4}>{title ?? name} Template</Title>
|
<Title order={4}>{title ?? name} Template</Title>
|
||||||
<UriGroup>
|
<UriGroup>
|
||||||
<UriText>{previewUri(uriTemplate, variables)}</UriText>
|
<UriText>{preview}</UriText>
|
||||||
<CopyButton value={previewUri(uriTemplate, variables)} />
|
<CopyButton value={preview} />
|
||||||
</UriGroup>
|
</UriGroup>
|
||||||
</HeaderRow>
|
</HeaderRow>
|
||||||
{description && <DescriptionText>{description}</DescriptionText>}
|
{description && <DescriptionText>{description}</DescriptionText>}
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue