inspector/clients/web/src
Repository files (latest commit first)
Filename Latest commit message Latest commit date
cliffhall a935de08dc fix(web): re-apply the write that settles after an overlapping one failed
Review round 5 on #2091, both findings.

The other overlap order was still wrong. Write 1 (`true`) is in flight
when write 2 (`false`) fails, so the rollback resolves to the stale
entry's `false` — correct at that instant, nothing had landed. Write 1
then lands `true` and only touched refs, so if its own list reload had
failed too, no render would ever correct the UI or the live client while
disk held `true`.

Writes now report both outcomes: `landed` returns whether this write is
the settled state for its server — recorded, with nothing later still in
flight — and `failed` takes a write out of flight so an earlier one that
lands afterwards settles. The toggle re-applies the settled value to the
override and the client, gated on its server still being active.

Serializing per server was the alternative and was not taken: it makes
the modal's debounced saves queue behind each other and changes the write
path to fix a UI-reconciliation concern, and it still could not order two
requests already in flight.

The override reset also moves from a `useEffect` to `useValueChange`,
which is what this repo requires for resetting state from render data —
the entry is referentially stable between reads, and keying on it alone
subsumes the persisted boolean and the server id.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UL9retfvAXRgvi6EWk4SY4
Signed-off-by: cliffhall <cliff@futurescale.com>
2026-08-23 12:40:15 -04:00
..
components Merge remote-tracking branch 'origin/v2/main' into v2/feat/1950-file-secret-store 2026-08-23 01:40:01 -04:00
hooks fix(web): re-apply the write that settles after an overlapping one failed 2026-08-23 12:40:15 -04:00
lib Merge remote-tracking branch 'origin/v2/main' into v2/feat/1950-file-secret-store 2026-08-23 01:40:01 -04:00
test Merge remote-tracking branch 'origin/v2/main' into v2/feat/1950-file-secret-store 2026-08-23 01:40:01 -04:00
theme fix(auth): address Copilot review round 2 on the secret-store PR 2026-08-22 12:51:14 -04:00
types chore: close a batch of quality-gate & tidy gaps (#1785 #1787 #1789 #1790 #1767) (#1792) 2026-07-26 10:43:11 -04:00
utils fix(auth): stop a config-only PUT deleting stored secrets (#2084) 2026-08-22 23:30:17 -04:00
App.css feat(auth): file-backed and in-memory SecretStore for hosts with no keychain 2026-08-22 12:06:31 -04:00
App.test.tsx fix(web): re-apply the write that settles after an overlapping one failed 2026-08-23 12:40:15 -04:00
App.tsx fix(web): re-apply the write that settles after an overlapping one failed 2026-08-23 12:40:15 -04:00
index.ts feat: port CLI, TUI, and launcher from v1.5 into v2 (#1452) 2026-06-14 20:27:49 -04:00
main.tsx fix(web): remove mantine-border-animate, use green highlight border (#1536) 2026-06-27 17:04:25 -04:00