- skill-manifest: the closing `---` fence must occupy a whole line. `---oops` was accepted as a terminator, silently truncating the frontmatter and passing validation — the exact failure the guard exists to catch. Regression cases added (prefix, trailing whitespace, EOF, CRLF). - skill-eval: reject a nonzero `claude -p` exit instead of resolving it as an empty observation. An auth error or rate limit was scoring as "no skill invoked", which passes every negative case and reads as a trigger miss on every positive one. - skill-eval: extract `collectSkillInvocations` / `sampleHit` behind a `main()` guard and cover them in `skill-eval.test.mjs` — the stream parsing and the process-outcome handling are unreachable from an eval run's happy path. - docs/test-servers: annotate the era on every catalogue row. Six legacy rows carried no annotation under a "unless noted, Modern" default, so the doc sent readers to the wrong era for the feature they were trying to see. - docs/quality-gate: `validate` runs four guards, not three; add the `verify:skills` row and the two new `test:scripts` suites; fix the `#publishing` fragment left dangling by the split. - issue-create / pr-flow: delegate the card steps to `/board-ops` rather than restating its option IDs, which are explicitly unstable. - issue-triage: the audit counted presence, not cardinality — an issue carrying both `v1` and `v2` passed a check that claims "exactly one". Same for the five type labels. Also scope the two milestone checks to board #28. - AGENTS.md: codify the v1 milestone exception. Every milestone is a v2 release bucket, so a v1 issue has none to take and the Incoming-milestone invariant cannot apply to board #11. - clients/launcher/README: its pointer promised an explanation of why the cli/tui manifests ship, which the extracted guide does not make. Signed-off-by: cliffhall <cliff@futurescale.com>
109 lines
4.9 KiB
Markdown
109 lines
4.9 KiB
Markdown
---
|
|
name: issue-create
|
|
description: Create a tracked Inspector issue end to end — version label, type label, milestone, board card, Status and Priority. Use when filing a new issue, or when work discovered mid-task needs an issue of its own.
|
|
disable-model-invocation: true
|
|
---
|
|
|
|
# Creating an issue
|
|
|
|
An issue **you** create is not "created" until all five of these are true. A
|
|
label is a repo tag, the milestone is a release bucket, and the board is a
|
|
separate org project — `--label v2` does **not** add a board card, and adding a
|
|
card does **not** set a Status or a Priority.
|
|
|
|
1. **Version label** — exactly one of `v1` / `v2`
|
|
2. **Type label** — exactly one of `bug` / `enhancement` / `documentation` / `chore` / `question`
|
|
3. **Milestone**
|
|
4. **A card on the board for that version** — `v2` → #28, `v1` → #11
|
|
5. **Status _and_ Priority set on that card** (Priority is v2-only)
|
|
|
|
Set the labels and milestone at **create time**, never by backfilling: an
|
|
unlabeled issue belongs to no version line and appears in no version-filtered
|
|
query, and an unmilestoned one drops out of release planning silently.
|
|
|
|
**Never create a duplicate.** Check the board for a matching item first.
|
|
**Never create a draft card** (a board card with no issue number) — every board
|
|
item is a real GitHub issue.
|
|
|
|
## 0. Check the board first
|
|
|
|
```sh
|
|
gh issue list --repo modelcontextprotocol/inspector --state open --limit 1000 \
|
|
--search "<keywords>" --json number,title,labels,milestone
|
|
```
|
|
|
|
## 1. Pick the labels
|
|
|
|
**Version.** `v2` is the default for anything new. `v1` is reserved for the
|
|
narrow case of patching the deprecated line (security fixes only). If the target
|
|
version isn't obvious, it's `v2` — only ask when the issue is specifically a fix
|
|
*for released v1 behavior* and it's unclear whether v2 still has the bug.
|
|
|
|
**Type.** Independent of the version label; every issue needs both.
|
|
|
|
| Type | Use for | Not for |
|
|
| --- | --- | --- |
|
|
| `bug` | Something is broken, wrong, or regressed against its intended behavior | A missing capability that was never built |
|
|
| `enhancement` | A new capability, or extending an existing one — features, spec support, tracking issues | A cleanup with no behavior change |
|
|
| `documentation` | Prose deliverables — READMEs, guides, `specification/` docs, `AGENTS.md` rules | Code that happens to need a doc update |
|
|
| `chore` | Maintenance with no user-facing behavior change — deps, build/CI tooling, refactors | Anything a user would notice |
|
|
| `question` | An open question or discussion with no agreed deliverable yet | Work someone has already decided to do |
|
|
|
|
**Don't force the binary.** `bug` and `enhancement` are the two most reached
|
|
for, and pressing a docs task or a dependency pin into `enhancement` degrades it
|
|
to "not a bug", at which point filtering by it stops telling you anything.
|
|
|
|
## 2. Pick the milestone
|
|
|
|
If the user didn't specify one, default to the **current** milestone: the open
|
|
one with the nearest due date.
|
|
|
|
```sh
|
|
gh api repos/modelcontextprotocol/inspector/milestones --jq \
|
|
'map(select(.state=="open")) | sort_by(.due_on) | .[] | "\(.title)\tdue \(.due_on[0:10])\topen=\(.open_issues)"'
|
|
```
|
|
|
|
Milestones are **release** buckets (`v2.1.0`, `v2.2.0`, …), so pick by *when the
|
|
work ships*, not by size. If a new issue plainly can't make the current
|
|
milestone, say so and put it in the next one rather than leaving it blank.
|
|
Sub-issues normally inherit their parent's milestone.
|
|
|
|
⚠️ **Every milestone is a v2 release bucket.** There is no v1 bucket, so a `v1`
|
|
issue cannot satisfy the milestone rule — don't drop it in a v2.x one. Leave it
|
|
unmilestoned and say so.
|
|
|
|
## 3. Create it
|
|
|
|
```sh
|
|
gh issue create --repo modelcontextprotocol/inspector \
|
|
--title "<title>" \
|
|
--label v2 --label bug \
|
|
--milestone "v2.5.0" \
|
|
--body "<body>"
|
|
```
|
|
|
|
## 4. Board it, in Todo
|
|
|
|
Filing an issue for work you intend to happen **is** approving it, so it starts
|
|
in **Todo** with its milestone already set — not in Incoming, which is the queue
|
|
for issues nobody has evaluated yet. Work you are starting immediately goes
|
|
straight to **In Progress**.
|
|
|
|
Run the **add-card recipe in `/board-ops`** with **Status → Todo** and the
|
|
Priority you scored. The project, field and option IDs live there and only
|
|
there: an option ID is regenerated whenever its field's option list is edited,
|
|
so a second copy here would go stale silently and break issue creation even
|
|
after `board-ops` was fixed.
|
|
|
|
For a **v1** issue, the same recipe against board #11 — no Priority, that board
|
|
has no such field.
|
|
|
|
The priority rubric is in `/issue-triage`.
|
|
|
|
## Note on issues that arrive from elsewhere
|
|
|
|
An issue opened by hand in the GitHub UI — by an outside reporter *or* by a
|
|
maintainer — arrives with no label, no milestone, and no card. That is normal on
|
|
arrival, not a defect to fix the moment it lands: it comes into the system
|
|
through `/issue-triage` instead, and starts in **Incoming** with no milestone,
|
|
because nobody has approved it.
|