modelcontextprotocol/java-sdk
Watch
1
0
Fork
You've already forked java-sdk
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: copy request builder to prevent side effects in HTTP transports (#333)

Browse source 
- Add .copy() call before modifying requestBuilder in FlowSseClient
- Add .copy() call before modifying requestBuilder in HttpClientSseClientTransport
- Prevents unintended mutations of shared builder instances
This commit is contained in:
jookunshuai 2025-06-20 17:11:19 +08:00 • committed by Christian Tzolov
commit fce7a6bad3
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
mcp/src/main/java/io/modelcontextprotocol/client/transport/FlowSseClient.java
View file

@ -121,7 +121,8 @@ public class FlowSseClient {
* @throws RuntimeException if the connection fails with a non-200 status code * @throws RuntimeException if the connection fails with a non-200 status code
*/ */
public void subscribe(String url, SseEventHandler eventHandler) { public void subscribe(String url, SseEventHandler eventHandler) {
HttpRequest request = this.requestBuilder.uri(URI.create(url)) HttpRequest request = this.requestBuilder.copy()
.uri(URI.create(url))
.header("Accept", "text/event-stream") .header("Accept", "text/event-stream")
.header("Cache-Control", "no-cache") .header("Cache-Control", "no-cache")
.GET() .GET()

3
mcp/src/main/java/io/modelcontextprotocol/client/transport/HttpClientSseClientTransport.java
View file

@ -415,7 +415,8 @@ public class HttpClientSseClientTransport implements McpClientTransport {
try { try {
String jsonText = this.objectMapper.writeValueAsString(message); String jsonText = this.objectMapper.writeValueAsString(message);
URI requestUri = Utils.resolveUri(baseUri, endpoint); URI requestUri = Utils.resolveUri(baseUri, endpoint);
HttpRequest request = this.requestBuilder.uri(requestUri) HttpRequest request = this.requestBuilder.copy()
.uri(requestUri)
.POST(HttpRequest.BodyPublishers.ofString(jsonText)) .POST(HttpRequest.BodyPublishers.ofString(jsonText))
.build(); .build();