modelcontextprotocol/inspector
Watch
1
0
Fork
You've already forked inspector
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

docs: name the two smokes that set 1280x900, not a wildcard

Browse source 
Copilot review round 2 on #2271: `scripts/smoke-web-*.mjs` overclaimed —
smoke-web-app.mjs and smoke-web-browser.mjs create pages with no viewport at
all, so only the tabs and elicitation smokes back the number. Name those two
explicitly and say the other two set none.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017nLLLTGc37hQiC8s3mNyhq
Signed-off-by: cliffhall <cliff@futurescale.com>
This commit is contained in:
cliffhall 2026-09-06 12:17:31 -04:00
commit edab149d5b
1 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
.claude/skills/pr-flow/SKILL.md
View file

@ -114,11 +114,13 @@ the web client. A **TUI** change has no viewport and no `fullPage` mode: size
the terminal so no line wraps or truncates, and go straight to 5b, which applies the terminal so no line wraps or truncates, and go straight to 5b, which applies
to every image regardless of how it was taken. to every image regardless of how it was taken.
**Shoot the web client at 1280×900, full page.** That is the viewport the web **Shoot the web client at 1280×900, full page.** It is the one size already
smokes already use (`scripts/smoke-web-*.mjs`), and adopting it as the standard written down anywhere in the repo — `scripts/smoke-web-tabs.mjs` and
here is what makes a reviewer comparing two PRs compare the same thing — the `scripts/smoke-web-elicitation.mjs` set exactly that viewport (the other two web
older shots checked into `specification/screenshots/` were taken at assorted smokes set none) — and adopting it as the standard here is what makes a reviewer
sizes, which is the problem, not the precedent. Prefer a full-page shot over a comparing two PRs compare the same thing. The older shots checked into
`specification/screenshots/` were taken at assorted sizes, which is the problem,
not the precedent. Prefer a full-page shot over a
Playwright `clip` region: a clip sized to one panel cuts off anything placed Playwright `clip` region: a clip sized to one panel cuts off anything placed
beside it, and two clips of different sizes make a before/after pair hard to beside it, and two clips of different sizes make a before/after pair hard to
read as a pair. read as a pair.