cliffhall
2fca87c0ad
chore(web): record the useProgressToasts return-type exception
...
Copilot's second pass accepted every code fix and re-raised one item:
useProgressToasts is the only extracted hook that returns nothing, which
contradicts #2128 's "each hook returns one object" criterion, and the
disagreement was recorded nowhere a reader would find it.
Its ask was either a result object or an explicit exception. Taking the
second: the hook subscribes, shows toasts and unsubscribes, and the only
state it owns is toast-id bookkeeping the caller must not see, so `{}`
would advertise an API that is not there. The criterion exists to stop a
hook handing back a long list of loose values — useTabUiState's
twenty-two is the case it was written against, and that one does return
a bundled object.
Noted in the hook's own doc block (so it reads as a decision rather than
an oversight) and on #2128 itself, so the acceptance criteria and the
implementation agree.
Signed-off-by: cliffhall <cliff@futurescale.com>
2026-08-26 20:10:55 -04:00
..
useExportActions.test.tsx
chore(web): address Copilot review on #2128
2026-08-26 19:58:02 -04:00
useExportActions.ts
chore(web): address Copilot review on #2128
2026-08-26 19:58:02 -04:00
useImportClientConfig.test.tsx
fix(web): stop the remaining consumers calling a landed write a failure
2026-08-23 10:14:22 -04:00
useImportClientConfig.ts
fix(web): stop the remaining consumers calling a landed write a failure
2026-08-23 10:14:22 -04:00
useInspectorStores.test.tsx
chore(web): address Copilot review on #2128
2026-08-26 19:58:02 -04:00
useInspectorStores.ts
chore(web): extract App.tsx's leaf hooks ( #2128 )
2026-08-26 19:42:16 -04:00
useLastPersistedSettings.test.tsx
fix(web): update a fixture the merge brought in to the object metadata shape
2026-08-23 16:56:53 -04:00
useLastPersistedSettings.ts
fix(web): apply the whole live surface, and track write outcomes per server
2026-08-23 13:56:36 -04:00
usePaginatedList.test.tsx
fix: surface list-fetch failures in paginated mode ( #1998 )
2026-08-17 20:40:23 -04:00
usePaginatedList.ts
fix: surface list-fetch failures in paginated mode ( #1998 )
2026-08-17 20:40:23 -04:00
usePaginatedListsOverride.test.tsx
fix: keep the pagination toggle on the last write across a server switch ( #2095 )
2026-08-25 20:20:57 -04:00
usePaginatedListsOverride.ts
fix: resolve the servers list outside the override's state updater ( #2095 )
2026-08-25 20:33:14 -04:00
useProgressToasts.test.tsx
chore(web): address Copilot review on #2128
2026-08-26 19:58:02 -04:00
useProgressToasts.ts
chore(web): record the useProgressToasts return-type exception
2026-08-26 20:10:55 -04:00
useScrollMemory.test.tsx
feat(web): tool progress toasts + persist all per-screen state across navigation ( #1414 , #1417 ) ( #1420 )
2026-06-03 12:46:37 -04:00
useScrollMemory.ts
feat(web): tool progress toasts + persist all per-screen state across navigation ( #1414 , #1417 ) ( #1420 )
2026-06-03 12:46:37 -04:00
useServerJsonImport.test.tsx
chore: close a batch of quality-gate & tidy gaps ( #1785 #1787 #1789 #1790 #1767 ) ( #1792 )
2026-07-26 10:43:11 -04:00
useServerJsonImport.ts
chore: close a batch of quality-gate & tidy gaps ( #1785 #1787 #1789 #1790 #1767 ) ( #1792 )
2026-07-26 10:43:11 -04:00
useTabUiState.test.tsx
chore(web): address Copilot review on #2128
2026-08-26 19:58:02 -04:00
useTabUiState.ts
chore(web): address Copilot review on #2128
2026-08-26 19:58:02 -04:00
useTaskToasts.test.tsx
chore(web): address Copilot review on #2128
2026-08-26 19:58:02 -04:00
useTaskToasts.ts
chore(web): address Copilot review on #2128
2026-08-26 19:58:02 -04:00
useThemeToggle.test.tsx
chore(web): extract App.tsx's leaf hooks ( #2128 )
2026-08-26 19:42:16 -04:00
useThemeToggle.ts
chore(web): extract App.tsx's leaf hooks ( #2128 )
2026-08-26 19:42:16 -04:00
useValueChange.test.tsx
chore(deps): migrate to eslint 10 to clear the brace-expansion DoS advisory ( #1900 )
2026-08-01 20:13:30 -04:00
useValueChange.ts
chore(deps): migrate to eslint 10 to clear the brace-expansion DoS advisory ( #1900 )
2026-08-01 20:13:30 -04:00